fix(module:datepicker): incorrect date format strings fix #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
culture set takes effect fallback to default local when locale json does not exist
ElderJames
approved these changes
Feb 5, 2021
|
Awesome! Thank you. |
This was
linked to
issues
Feb 5, 2021
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
* fix(module:datepicker): incorrect date format strings fix culture set takes effect fallback to default local when locale json does not exist * fix(module:datepicker): do not replace Locale if is set in attribute
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
* fix(module:datepicker): incorrect date format strings fix culture set takes effect fallback to default local when locale json does not exist * fix(module:datepicker): do not replace Locale if is set in attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
#1044
#1093
馃挕 Background and solution
Most of locale
.jsonfile had incorrect string template (YYYYinstead ofyyyyandDinstead ofd).LocaleProviderwas usingCultureInfo.DefaultThreadCurrentUICulturefor detection of current culture. But this is not working well with server version - there is a high possibility it will pick up server's UI instead of browser's UI. A switch was done toCultureInfo.CurrentUICulturefor detection.In
DatePickerif theCultureInfoattribute was used without settingLocaleattribute, still onlyCultureInfo.DefaultThreadCurrentUICulturewas being picked up. The fix is to detect if parameterCultureInfowas set outside and force load theLocalewith passedCultureInfo. This exposed a situation when culture file does not exist (in my case I was trying to useel-CYand it was crashing). Fallback logic was added and default locale is picked up if no locale.jsonfile is found.鈽戯笍 Self Check before Merge