-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(model: overlay): add boundary detection adjustment #1109
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
=========================================
- Coverage 6.60% 6.59% -0.02%
=========================================
Files 436 436
Lines 24165 24233 +68
=========================================
+ Hits 1596 1598 +2
- Misses 22569 22635 +66
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mutouzdl Sorry to bother you about this, but I am trying to work out the overlay boundary calculation. I cannot figure out what is the meaning of |
@anddrzejb It's a little hard to understand, and I'll probably give you two examples to illustrate it. Example1: In InScroll mode, in this case, the menu will appear on top. Example2: In InScroll mode, the following situation will display the menu below. If anything is unclear, I will try to explain further. |
@mutouzdl Thanks for the explanation! I think I understand now. So, we have these scenarios for calculations:
|
@anddrzejb Yes, your interpretation is correct, and your summary is very accurate! |
I will add this or similar explanation to the docs once I finish. |
@mutouzdl I have another question. I am trying to wrap my head around parameter |
@anddrzejb Yes, your understanding is correct. ArrowPointAtCenter is used for ToolTip and other components. If ArrowPointAtCenter=true, the arrow will point to the center of the target element: |
@mutouzdl I thought so. I was a bit confused by the calculation based on the arrow shifts. But the redesign will just switch internally to appropriate cantered placement I guess. |
* feat(model: overlay): add boundary detection and orientation adjustment * feat: suport inview and inscroll mode
* feat(model: overlay): add boundary detection and orientation adjustment * feat: suport inview and inscroll mode
🤔 This is a ...
🔗 Related issue link
#1081
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge