Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:select): property rename to follow docs #1115

Merged
merged 2 commits into from
Feb 8, 2021
Merged

fix(module:select): property rename to follow docs #1115

merged 2 commits into from
Feb 8, 2021

Conversation

anddrzejb
Copy link
Member

@anddrzejb anddrzejb commented Feb 7, 2021 •
edited

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#1111

💡 Background and solution

  1. Renamed DefaultActiveFirstItem to DefaultActiveFirstOption following the docs (it is in sync with react antDesign)
  2. When current locale are of a country that uses comma as decimal separator, the calculated css width was delivered with a comma (for example 333,123123). Css was not understanding that and was ignoring the value.
  3. Translated Chinese comment.
  4. Fix similar to [select] DefaultValue does not take effect when the select component enables remote search #662 that was applier to DefaultActiveFirstOption
  5. Changing bound object to value outside of the Select component wasn't changing selection in the component.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@anddrzejb
fix(module:select): property rename to follow docs
21cae00 
comma in decimal causing wrong css value for select box width

comment translation
ElderJames
ElderJames approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit dd50790 into ant-design-blazor:master Feb 8, 2021
@ElderJames ElderJames linked an issue Feb 8, 2021 that may be closed by this pull request
The component Select property DefaultActiveFirstOption is invalid #1111
Closed
@anddrzejb anddrzejb deleted the selectFix branch February 9, 2021 18:22
@anddrzejb anddrzejb mentioned this pull request Feb 18, 2021
Closed
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
@anddrzejb
fix(module: select): property rename to follow docs (#1115)
c45eefe 
* fix(module:select): property rename to follow docs

comma in decimal causing wrong css value for select box width

comment translation

* fix(module:select): delayed DefaultActiveFirstOption fix

change of values fix
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
@anddrzejb
fix(module: select): property rename to follow docs (#1115)
b0c9509 
* fix(module:select): property rename to follow docs

comma in decimal causing wrong css value for select box width

comment translation

* fix(module:select): delayed DefaultActiveFirstOption fix

change of values fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElderJames ElderJames ElderJames approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
0.7.0 - MILESTONE: February 2021
Development

Successfully merging this pull request may close these issues.

The component Select property DefaultActiveFirstOption is invalid
2 participants
@anddrzejb @ElderJames