fix(module:select): new tag item label and value fix #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anddrzejb Could you please cherry-pick the menu commit to another branch? |
|
Ok, will do that. |
anddrzejb
force-pushed
the
selectNewTagFix
branch
from
32cd7d4
to
383678d
Compare
ElderJames
approved these changes
Feb 14, 2021
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
* fix(module:select): new tag item label and value fix * fix: interop firefox "Permission Denied" fix * fix(module:select): prefixIcon styling and positioning
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
* fix(module:select): new tag item label and value fix * fix: interop firefox "Permission Denied" fix * fix(module:select): prefixIcon styling and positioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃挕 Background and solution
When
Mode="tags"set, newly createdSelectOptionItemwas not being properly updated.Itemproperty was only created with initial letter and no updates were done further.Edit: I accidentally pushed to the same branch fixes for #1110, so I will leave them here as well...(moved to PR #1134)Menuexcept the fix got some extra optimization. I also noticed that accordion is not working but since @mutouzdl is doing some heavy work in that area, I will not be touching it.Edit2:
originalTargetof dom element. So I am omitting that...PrefixIconforSelectcomponent. It wasn't playing nice with placeholder/input cursor. Also it was not shown when selected items were visible in the select box (for tags/multiple).鈽戯笍 Self Check before Merge