Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): support more generic units for scroll x/y #1137

Merged
merged 2 commits into from
Feb 14, 2021

Conversation

ElderJames
Copy link
Member

@ElderJames ElderJames commented Feb 14, 2021

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #1046

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English support more generic units for scroll x/y
🇨🇳 Chinese ScrollX/ScrollY 增加更多长度单位的支持

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@codecov-io
Copy link

codecov-io commented Feb 14, 2021

Codecov Report

Merging #1137 (80185ec) into master (6e29be5) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1137      +/-   ##
=========================================
- Coverage    6.58%   6.58%   -0.01%     
=========================================
  Files         436     436              
  Lines       24293   24313      +20     
=========================================
  Hits         1600    1600              
- Misses      22693   22713      +20     
Impacted Files Coverage Δ
components/core/CssSizeLength.cs 0.00% <0.00%> (ø)
components/table/ColumnBase.cs 0.00% <0.00%> (ø)
components/table/ColumnContext.cs 0.00% <0.00%> (ø)
components/table/TableModels/SortModel.cs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e29be5...80185ec. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ScrollY/ScrollX property of the table needs to support % and other units
2 participants