fix(module:row): grid gutter fix #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElderJames
approved these changes
Feb 23, 2021
ElderJames
added a commit
that referenced
this pull request
Apr 23, 2022
* fix(module:row): grid gutter switch to row-gap * docs(module:grid): gutter docs in sync with react antDesign * add DefaultBreakpoint Co-authored-by: ElderJames <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Apr 30, 2022
* fix(module:row): grid gutter switch to row-gap * docs(module:grid): gutter docs in sync with react antDesign * add DefaultBreakpoint Co-authored-by: ElderJames <shunjiey@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
#610
馃挕 Background and solution
The grid was basically working (although not exactly as in react), but the demo was wrong and it was screwing up the grid.
Changes made:
Gutterxtogutterbecause the demo has specific css for id="components-grid-demo-gutter" (@Hona, I had to make this change here, please pull it into your PR once it is merged).One thing that I did not manage to bring in sync with react is the order of classes for
Colcomponent. In react, thiswill render to
Same in antBlazor will render to:
The problem here is
ClassMapperandOriginalClassproperty. ForColI was trying to reset it and add it in the end, but it still comes back (I guess because it is a[Parameter]) and I was ending up with<div class="gutter-row ant-col ant-col-6 gutter-row">. I could probably reset it in theSetParametermethod? For the time being it seems to work, and maybe we do not need to touch it, but because it is different than react, I wanted to bring it to your attention.鈽戯笍 Self Check before Merge