-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] refactor: list #117
[WIP] refactor: list #117
Conversation
/preview |
components/space/SpaceItem.razor.cs
Outdated
[Parameter] | ||
public RenderFragment ChildContent { get; set; } | ||
|
||
private static readonly Hashtable _spaceSize = new Hashtable() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议注释单位是像素
components/space/SpaceItem.razor.cs
Outdated
var size = Parent.Size; | ||
var direction = Parent.Direction; | ||
|
||
var marginSize = size.IsIn("small", "middle", "large") ? _spaceSize[size] : size; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有大量重复的字符串,推荐添加一个常量字段
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
refactor: list