Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor: list #117

Merged
merged 1 commit into from
May 22, 2020
Merged

[WIP] refactor: list #117

merged 1 commit into from
May 22, 2020

Conversation

setli
Copy link
Contributor

@setli setli commented May 15, 2020

refactor: list

@ElderJames
Copy link
Member

/preview

@github-actions
Copy link

github-actions bot commented May 15, 2020

[Parameter]
public RenderFragment ChildContent { get; set; }

private static readonly Hashtable _spaceSize = new Hashtable()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议注释单位是像素

var size = Parent.Size;
var direction = Parent.Direction;

var marginSize = size.IsIn("small", "middle", "large") ? _spaceSize[size] : size;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有大量重复的字符串,推荐添加一个常量字段

@setli setli changed the title refactor: list [WIP] refactor: list May 21, 2020
Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ElderJames ElderJames merged commit 2c22a2e into ant-design-blazor:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants