fix(module:avatar): text size calc regional independent #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@ElderJames I think the same problem might have been in |
|
@anddrzejb Please fix the overlay at another PR, within the JS issue |
ElderJames
approved these changes
Apr 15, 2021
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
* fix(module:avatar): text size calc regional independent * fix(module: avatar): removed limitation on number of decimal laces
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
* fix(module:avatar): text size calc regional independent * fix(module: avatar): removed limitation on number of decimal laces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
Fixes #1340
馃挕 Background and solution
When scale was applied to styles, it was not made regional settings resilient. So there would be a scenario when avatar style would get something like this
scale(0,9340293843421312)(with comma instead of dot). So when jsgetDomInfowas reading this, it was getting a value that was much grater than Int32. When c# was trying to put that into Int32, it was failing, thus exception.@TsakiDev, thank you for you invaluable help! I could not have discovered this without your help.
鈽戯笍 Self Check before Merge