Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to use tag name as nuget version #157

Closed
wants to merge 2 commits into from
Closed

Try to use tag name as nuget version #157

wants to merge 2 commits into from

Conversation

lindexi
Copy link
Contributor

@lindexi lindexi commented May 27, 2020

Close #151

@ElderJames
Copy link
Member

Thank you for your contribution @lindexi .
But I think this can be done using a pure bash script. Can you give a hand with this?

@ElderJames ElderJames added enhancement New feature or request and removed PR: unreviewed labels May 28, 2020
@lindexi
Copy link
Contributor Author

lindexi commented May 28, 2020

@ElderJames

We can be implemented in pure script logic, not in the form of writing files.

可以纯脚本逻辑实现,不通过写入文件的形式

@lindexi
Copy link
Contributor Author

lindexi commented May 28, 2020

@ElderJames 默认使用辅助工具转换也是应该的,毕竟 GitHub 的 Action 设计上就是期望能通过引入工具减少脚本复杂度和提升配置管理效率

@lindexi
Copy link
Contributor Author

lindexi commented May 29, 2020

@ElderJames 好了,现在是干掉了 Version.props 文件了,通过命令传入版本号

@ElderJames ElderJames added duplicate This issue or pull request already exists and removed PR: unreviewed enhancement New feature or request labels Jun 28, 2020
@ElderJames
Copy link
Member

I implemented it in another PR #267 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists PR: unreviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release through tagging
2 participants