fix(module: upload): treat 2xx response codes success #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat all 2xx status codes as success in the upload module.
|
|
Codecov Report
@@ Coverage Diff @@
## master #1705 +/- ##
=======================================
Coverage 17.92% 17.92%
=======================================
Files 448 448
Lines 29182 29182
=======================================
Hits 5230 5230
Misses 23952 23952 Continue to review full report at Codecov.
|
ElderJames
reviewed
Jul 4, 2021
ElderJames
added a commit
that referenced
this pull request
Jul 16, 2021
* fix(module: grid): gutter adjustment on col initialize (#1653) * feat(module: form): add advanced search demo (#1654) * fix(module: tag): show pointer cursor when OnClick.HasDelegate (#1660) * fix(module: form): fix input components inside customized form control (#1662) * chore: enable AOT for docs site (#1656) * Build AOT site * remove package publish Co-authored-by: ElderJames <shunjiey@hotmail.com> * fix(module: date-picker): fix low datetime error (#1663) * fix(module: date-picker): Date picker blur/focus & regression tests (#1681) * fix(module:datepicker): locale & blur issue fix * tests(module:datepicker): add regression tests * fix: focus is kept on picker false click & blur is applied when needed * fix: tests * fix(module: table): allow set filters after table initialization (#1667) * fix(module:table): allow set filters after table initialization * Update Column.razor.cs * feat(module: form): use DisplayName attribute as the default FormItem Label (#1682) * add. 如果没有设置FormItem的Label参数，则尝试使用绑定字段的DisplayName * Update components/form/FormItem.razor.cs Co-authored-by: 陈斌 <chenb@teleware.cn> Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: space): fix space items behavior when they are inside `if` block (#1684) * fix(module:space): fix space item margin * remove Index parameter * remove additional using * Update Customize.razor space demo * Update SpaceItem.razor * fix(module: checkbox): remove redundant class (#1689) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): add PopupContainerSelector for filter and/or selector (#1687) * fix(module:table): add PopupContainerSelector for filter and/or selector * Update Column.razor * fix(module: date-picker): fix date picker width (#1685) * fix(module:date-picker): fix date picker width * Update DatePickerBase.cs * fix(module: checkbox): fix the test following up PR #1689 (#1699) * fix(module: checkbox): fix tests * fix testkit package * feat(module: table): support expanding all items in table (#1695) Add the ability to have all items in a table by setting DefaultExpandAllRows to true. Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: upload): treat 2xx response codes success (#1705) Treat all 2xx status codes as success in the upload module. * fix aot build * fix(module: overlay): better judge whether mouse is inside the trigger when click (#1692) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: locale-provider): add missing nodes default values (#1710) * fix(i18n): russian locale resources additions (#1709) * Russian locale resources additions Based on #1707 * Change 'firstDayOfWeek' to 'Monday' * fix(module: statistic): fix CountDown OnFinish callback exception(#1712) (#1714) Calls to OnFinish callback now won't cause InvalidOperationException. * fix(module: upload): UploadFileItem Provide default configuration: ignore case (#1717) * feat(module: tabs): scroll over tab pane (#1581) * feat(module: tabs): scroll over tab pane * feat(module: tabs): drop down hide visible tabs * clean up the code Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): allow change both data source and value in one render period (#1720) * fix(module:select): allow change both datasource and value in one render period * Update Select.razor.cs * Update Select.razor.cs * Update Select.razor.cs * fix(module: dialog): Modal and Drawer render reducing and update document and demo (#1701) * fix(module: Modal&Drawer): render reducing and demo update * docs(module: modal): add FAQ section * docs: add English comments * fix: wrong format in Modal_service_for_confirm.razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * chore: refactor the build process (#1729) * refactor the build process * add message * changelog 0.8.3 (#1730) * change 0.8.3 * Update CHANGELOG.zh-CN.md * Update CHANGELOG.en-US.md * fix build process for static web assets * code style change * code style change * Update Tabs.razor.cs * Update Tabs.razor.cs * Update Tabs.razor.cs Co-authored-by: James Yeung <shunjiey@hotmail.com> Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: Newbe36524 <newbe36524@qq.com> Co-authored-by: gmij <gmij@qq.com> Co-authored-by: 陈斌 <chenb@teleware.cn> Co-authored-by: Zonciu Liang <zonciu@zonciu.com> Co-authored-by: Henrik Widlund <4659350+henrikwidlund@users.noreply.github.com> Co-authored-by: kuznecovIT <62954135+kuznecovIT@users.noreply.github.com> Co-authored-by: HexJacaranda <rbqlzg1937n@msn.com> Co-authored-by: BeiYinZhiNian <1031622947@qq.com> Co-authored-by: Brian Ding <brian_ding@outlook.com> Co-authored-by: zxyao <zxyao145@gmail.com>
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
Treat all 2xx status codes as success in the upload module.
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
Treat all 2xx status codes as success in the upload module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat all 2xx status codes as success in the upload module.
🤔 This is a ...
🔗 Related issue link
#1655 (The 'Upload' component will treat the 201 (created) HTTP status code as a failure result)
💡 Background and solution
Depending on how the server receiving to the uploaded file is configured, successful requests might not be responded with 200 as a status code. Fix is to be less strict and treat any 2xx status code as successful.
📝 Changelog
☑️ Self Check before Merge