fix(module: select): can not set initial value for non-datasource approach #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1743 +/- ##
==========================================
+ Coverage 17.91% 17.92% +0.01%
==========================================
Files 448 448
Lines 29261 29271 +10
==========================================
+ Hits 5241 5248 +7
- Misses 24020 24023 +3
Continue to review full report at Codecov.
|
ElderJames
force-pushed
the
master
branch
3 times, most recently
from
367e011
to
bdcc42c
Compare
ElderJames
approved these changes
Jul 19, 2021
ElderJames
added a commit
that referenced
this pull request
Apr 23, 2022
…roach (#1743) * fix(module: select): can not set initial value for non-datasource approach * Update Select.razor.cs Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Apr 30, 2022
…roach (#1743) * fix(module: select): can not set initial value for non-datasource approach * Update Select.razor.cs Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fixes #1735
💡 Background and solution
A sample:
This issue is introduced by #1720 . In #1720, I changed the position to call
OnValueChangemethod. In most cases, this change is safe. However,OnValueChangeshould do nothing for the first call(by evaluating the_isInitializedfield), but the method is now first called after_isInitializedis set totrue. We can solve this issue by simply move_isInitialized = true;to after the call toOnValueChange. Let me know if you think we should use a new variable or variable name in this case.📝 Changelog
☑️ Self Check before Merge