Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): duplicated tags #1766

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

anddrzejb
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

  1. Fixes Select component in 'tags' mode is duplicating tags #1645
  2. Any mouse button click on "x" in selected item is removing it.

💡 Background and solution

  1. SelectOption was being removed in the Dispose() method irrespective of it being selected. Dispose method now checks if SelectOption is selected and prevents removing.
  2. Selected item will be removed only if the "x" receives left mouse button click.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 23, 2021

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #1766 (8def743) into master (367e011) will increase coverage by 1.41%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1766      +/-   ##
==========================================
+ Coverage   17.91%   19.33%   +1.41%     
==========================================
  Files         448      448              
  Lines       29261    29286      +25     
==========================================
+ Hits         5241     5661     +420     
+ Misses      24020    23625     -395     
Impacted Files Coverage Δ
components/select/internal/SelectContent.razor 34.53% <0.00%> (+20.14%) ⬆️
components/select/internal/SelectContent.razor.cs 47.01% <0.00%> (+15.26%) ⬆️
components/select/Select.razor.cs 35.20% <57.14%> (+16.48%) ⬆️
components/select/SelectOption.razor.cs 77.39% <100.00%> (+35.32%) ⬆️
components/icon/internal/IconStore.cs 19.70% <0.00%> (+0.06%) ⬆️
components/core/Helpers/THelper.cs 37.77% <0.00%> (+13.33%) ⬆️
components/select/internal/SelectOptionItem.cs 76.76% <0.00%> (+23.23%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015129c...8def743. Read the comment docs.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit cbe94d1 into ant-design-blazor:master Jul 23, 2021
@anddrzejb anddrzejb deleted the selectDuplicateTags branch July 29, 2021 12:10
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select component in 'tags' mode is duplicating tags
2 participants