fix: unexpected behavior of Drawer(#1749) #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The scroll bar of the body is enabled after closing one of the multiple drawers 2. Bad parameter NoAnimation.
|
|
ElderJames
reviewed
Jul 24, 2021
components/drawer/Drawer.razor.cs
Outdated
| { | ||
| get | ||
| { | ||
| Console.WriteLine("InnerZIndexStyle " + _status); |
There was a problem hiding this comment.
Please remove the Console.WriteLine
Codecov Report
@@ Coverage Diff @@
## master #1771 +/- ##
==========================================
+ Coverage 17.91% 19.33% +1.42%
==========================================
Files 448 449 +1
Lines 29262 29282 +20
==========================================
+ Hits 5241 5661 +420
+ Misses 24021 23621 -400
Continue to review full report at Codecov.
|
ElderJames
approved these changes
Jul 25, 2021
anddrzejb
pushed a commit
to anddrzejb/ant-design-blazor
that referenced
this pull request
Jul 26, 2021
…nt-design-blazor#1771) * fix: unexpected behavior of Drawer(ant-design-blazor#1749) 1. The scroll bar of the body is enabled after closing one of the multiple drawers 2. Bad parameter NoAnimation. * chore: remove debug output * chore: add comments for ComponentStatus * fix: different behaviors in WASM and Server modes * chore: remove debug output
anddrzejb
pushed a commit
to anddrzejb/ant-design-blazor
that referenced
this pull request
Jul 29, 2021
…nt-design-blazor#1771) * fix: unexpected behavior of Drawer(ant-design-blazor#1749) 1. The scroll bar of the body is enabled after closing one of the multiple drawers 2. Bad parameter NoAnimation. * chore: remove debug output * chore: add comments for ComponentStatus * fix: different behaviors in WASM and Server modes * chore: remove debug output
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
* fix: unexpected behavior of Drawer(#1749) 1. The scroll bar of the body is enabled after closing one of the multiple drawers 2. Bad parameter NoAnimation. * chore: remove debug output * chore: add comments for ComponentStatus * fix: different behaviors in WASM and Server modes * chore: remove debug output
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
* fix: unexpected behavior of Drawer(#1749) 1. The scroll bar of the body is enabled after closing one of the multiple drawers 2. Bad parameter NoAnimation. * chore: remove debug output * chore: add comments for ComponentStatus * fix: different behaviors in WASM and Server modes * chore: remove debug output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#1749
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge