Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(module:tree): rename Checked/Dechecked methods to Check/Uncheck #1792

Merged
merged 2 commits into from
Jul 30, 2021
Merged

refactor(module:tree): rename Checked/Dechecked methods to Check/Uncheck #1792

merged 2 commits into from
Jul 30, 2021

Conversation

lukblazewicz
Copy link
Contributor

BREAKING CHANGE

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

💡 Background and solution

Inaccurate name and description of the methods.

📝 Changelog

BREAKING CHANGE - method names changed

Language Changelog
🇺🇸 English Amend name and description of the methods for checking and unchecking all nodes in a tree.
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 29, 2021 •
edited

@lukblazewicz
Copy link
Contributor Author

@ElderJames
It's a follow up to the following discussion:
#1790

@codecov
Copy link

codecov bot commented Jul 29, 2021 •
edited

Codecov Report

Merging #1792 (d0d0872) into feature (e78f820) will decrease coverage by 20.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #1792       +/-   ##
===========================================
- Coverage    20.75%   0.00%   -20.76%     
===========================================
  Files          478     478               
  Lines        30491   30491               
===========================================
- Hits          6328       0     -6328     
- Misses       24163   30491     +6328
Impacted Files Coverage Δ
components/tree/Tree.razor.cs 0.00% <ø> (ø)
components/grid/Col.razor 0.00% <0.00%> (-100.00%) ⬇️
components/radio/Radio.razor 0.00% <0.00%> (-100.00%) ⬇️
components/core/ForwardRef.cs 0.00% <0.00%> (-100.00%) ⬇️
components/button/Button.razor 0.00% <0.00%> (-100.00%) ⬇️
components/empty/EmptyLocale.cs 0.00% <0.00%> (-100.00%) ⬇️
components/select/EnumSelect.cs 0.00% <0.00%> (-100.00%) ⬇️
components/input/InputGroup.razor 0.00% <0.00%> (-100.00%) ⬇️
components/radio/RadioGroup.razor 0.00% <0.00%> (-100.00%) ⬇️
components/badge/BadgeRibbon.razor 0.00% <0.00%> (-100.00%) ⬇️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e78f820...d0d0872. Read the comment docs.

@ElderJames ElderJames merged commit 5ea7bf3 into ant-design-blazor:feature Jul 30, 2021
ElderJames added a commit that referenced this pull request Sep 14, 2021
@ElderJames @lukblazewicz
@YongQuan-dotnet @anranruye @anddrzejb @zxyao145 @heroboy @SimonCropp @JohnHao421 @SapientGuardian @iamSmallY @stefanodriussi @Guyiming @CAPCHIK @nikolaykrondev @gmij @lxyruanjian @rabberbock @Chandankkrr @Hona @tonyyip1969 @SmRiley
Merge feature to master (#1945)
e1f0b2f 
* chore: sync ant-design v4.16.9 (#1782)

* refactor(module: tree): rename Checked/Dechecked methods to Check/Uncheck (#1792)

* feat(model: table): support responsive (#1802)

* feat(module: form): add properties Help, ValidateStatus and HasFeedback (#1807)

* Add properties Help, ValidateStatus and HasFeedback to FormItem

* refactor validation messages

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* feat(module: radio): add options for radio group (#1839)

* feat(module: radio): support enum type for `RadioGroup` (#1840)

* feat(module: image): support preview visible (#1842)

* feat(module: tree): add ChildContent for Tree and TreeNode (#1887)

* feat(module: tree): add ChildContent for Tree and TreeNode

Allow user set tree nodes directly.

* fix indent

* docs: Update the style to be compatible with antd 4.16 style. (#1893)

* docs: fix style

* fix logo font

* fix the color less

* feat(module: TreeSelect): add tree-select component 🚀 (#1773)

* fixed. Fix network error when requesting contributor list in local development environment

* fixed. Fix Chinese garbled code

* Update Dynamic.razor

* update. Adjust the base class of the select control to selectbase, and extract the common methods to prepare for tree select.

* fixed. Adjust the type of the parent control to selectbase

* tree-select完成基础编码工作。

* fix. 重新修订冲突解决时误删的变量

* fix. 修复在多选模式下无法显示初始值的bug

* fix some styles

* add. tree add Node UnSelect Event

* fix . Node Multiple Select Bug.

* fix Tree UnSelect invalid.

* fix. tree multiple select support.

* fix. select option sync tree node selected.

* fix. multiple select, old selected values has clear

* fix loop update exception

* 修复合并带来的冲突

* add. allow clear feat. but not finish.

* fix merge bug

* fix merge bug

* fix. supplementary notes

* update demo data with react demo

* add. 添加静态下拉树的能力，以及单选和多选的demo

* fix. 优化下拉显示树时，树选项的选中逻辑。

* fix demo

* fix. 静态下拉树时，出现错选的bug

* fix merge bugs.

* fix merge bugs.

* add. static dataObject Bind Support

* 将下拉树中，对偏平数据源的处理，移到simpleTreeSelect中

* fix ChildrenExpression

* feat: add dynamic component (#1703)

* feat: weakly-typed/dynamic component

* add TypeName support

* override BuildRenderTree instead of using a RenderFragment

* rename

* fix(module: timeline): label missing (#1941)

* chore: sync ant-design v4.16.13 (#1862)

Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: gmij <gmij@qq.com>
Co-authored-by: anranruye <hehewewe@hotmail.com>
Co-authored-by: Alan.Liu <lxyruanjian@126.com>
Co-authored-by: rabberbock <rabberbock@gmail.com>
Co-authored-by: Andrzej Bakun <anddrzejb@poczta.fm>
Co-authored-by: Chandan Rauniyar <chandankkrr@gmail.com>
Co-authored-by: Luke Parker [SSW] <10430890+Hona@users.noreply.github.com>
Co-authored-by: Tony Yip <tonyyip1969@gmail.com>
Co-authored-by: SmRiley <45205313+SmRiley@users.noreply.github.com>
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
@lukblazewicz
refactor(module: tree): rename Checked/Dechecked methods to Check/Unc…
47d5cf6 
…heck (#1792)
ElderJames added a commit that referenced this pull request Apr 23, 2022
@ElderJames @lukblazewicz
@YongQuan-dotnet @anranruye @anddrzejb @zxyao145 @heroboy @SimonCropp @JohnHao421 @SapientGuardian @iamSmallY @stefanodriussi @Guyiming @CAPCHIK @nikolaykrondev @gmij @lxyruanjian @rabberbock @Chandankkrr @Hona @tonyyip1969 @SmRiley
Merge feature to master (#1945)
d3e163f 
* chore: sync ant-design v4.16.9 (#1782)

* refactor(module: tree): rename Checked/Dechecked methods to Check/Uncheck (#1792)

* feat(model: table): support responsive (#1802)

* feat(module: form): add properties Help, ValidateStatus and HasFeedback (#1807)

* Add properties Help, ValidateStatus and HasFeedback to FormItem

* refactor validation messages

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* feat(module: radio): add options for radio group (#1839)

* feat(module: radio): support enum type for `RadioGroup` (#1840)

* feat(module: image): support preview visible (#1842)

* feat(module: tree): add ChildContent for Tree and TreeNode (#1887)

* feat(module: tree): add ChildContent for Tree and TreeNode

Allow user set tree nodes directly.

* fix indent

* docs: Update the style to be compatible with antd 4.16 style. (#1893)

* docs: fix style

* fix logo font

* fix the color less

* feat(module: TreeSelect): add tree-select component 🚀 (#1773)

* fixed. Fix network error when requesting contributor list in local development environment

* fixed. Fix Chinese garbled code

* Update Dynamic.razor

* update. Adjust the base class of the select control to selectbase, and extract the common methods to prepare for tree select.

* fixed. Adjust the type of the parent control to selectbase

* tree-select完成基础编码工作。

* fix. 重新修订冲突解决时误删的变量

* fix. 修复在多选模式下无法显示初始值的bug

* fix some styles

* add. tree add Node UnSelect Event

* fix . Node Multiple Select Bug.

* fix Tree UnSelect invalid.

* fix. tree multiple select support.

* fix. select option sync tree node selected.

* fix. multiple select, old selected values has clear

* fix loop update exception

* 修复合并带来的冲突

* add. allow clear feat. but not finish.

* fix merge bug

* fix merge bug

* fix. supplementary notes

* update demo data with react demo

* add. 添加静态下拉树的能力，以及单选和多选的demo

* fix. 优化下拉显示树时，树选项的选中逻辑。

* fix demo

* fix. 静态下拉树时，出现错选的bug

* fix merge bugs.

* fix merge bugs.

* add. static dataObject Bind Support

* 将下拉树中，对偏平数据源的处理，移到simpleTreeSelect中

* fix ChildrenExpression

* feat: add dynamic component (#1703)

* feat: weakly-typed/dynamic component

* add TypeName support

* override BuildRenderTree instead of using a RenderFragment

* rename

* fix(module: timeline): label missing (#1941)

* chore: sync ant-design v4.16.13 (#1862)

Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: gmij <gmij@qq.com>
Co-authored-by: anranruye <hehewewe@hotmail.com>
Co-authored-by: Alan.Liu <lxyruanjian@126.com>
Co-authored-by: rabberbock <rabberbock@gmail.com>
Co-authored-by: Andrzej Bakun <anddrzejb@poczta.fm>
Co-authored-by: Chandan Rauniyar <chandankkrr@gmail.com>
Co-authored-by: Luke Parker [SSW] <10430890+Hona@users.noreply.github.com>
Co-authored-by: Tony Yip <tonyyip1969@gmail.com>
Co-authored-by: SmRiley <45205313+SmRiley@users.noreply.github.com>
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
@lukblazewicz
refactor(module: tree): rename Checked/Dechecked methods to Check/Unc…
76ae40f 
…heck (#1792)
ElderJames added a commit that referenced this pull request Apr 30, 2022
@ElderJames @lukblazewicz
@YongQuan-dotnet @anranruye @anddrzejb @zxyao145 @heroboy @SimonCropp @JohnHao421 @SapientGuardian @iamSmallY @stefanodriussi @Guyiming @CAPCHIK @nikolaykrondev @gmij @lxyruanjian @rabberbock @Chandankkrr @Hona @tonyyip1969 @SmRiley
Merge feature to master (#1945)
d27be83 
* chore: sync ant-design v4.16.9 (#1782)

* refactor(module: tree): rename Checked/Dechecked methods to Check/Uncheck (#1792)

* feat(model: table): support responsive (#1802)

* feat(module: form): add properties Help, ValidateStatus and HasFeedback (#1807)

* Add properties Help, ValidateStatus and HasFeedback to FormItem

* refactor validation messages

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* feat(module: radio): add options for radio group (#1839)

* feat(module: radio): support enum type for `RadioGroup` (#1840)

* feat(module: image): support preview visible (#1842)

* feat(module: tree): add ChildContent for Tree and TreeNode (#1887)

* feat(module: tree): add ChildContent for Tree and TreeNode

Allow user set tree nodes directly.

* fix indent

* docs: Update the style to be compatible with antd 4.16 style. (#1893)

* docs: fix style

* fix logo font

* fix the color less

* feat(module: TreeSelect): add tree-select component 🚀 (#1773)

* fixed. Fix network error when requesting contributor list in local development environment

* fixed. Fix Chinese garbled code

* Update Dynamic.razor

* update. Adjust the base class of the select control to selectbase, and extract the common methods to prepare for tree select.

* fixed. Adjust the type of the parent control to selectbase

* tree-select完成基础编码工作。

* fix. 重新修订冲突解决时误删的变量

* fix. 修复在多选模式下无法显示初始值的bug

* fix some styles

* add. tree add Node UnSelect Event

* fix . Node Multiple Select Bug.

* fix Tree UnSelect invalid.

* fix. tree multiple select support.

* fix. select option sync tree node selected.

* fix. multiple select, old selected values has clear

* fix loop update exception

* 修复合并带来的冲突

* add. allow clear feat. but not finish.

* fix merge bug

* fix merge bug

* fix. supplementary notes

* update demo data with react demo

* add. 添加静态下拉树的能力，以及单选和多选的demo

* fix. 优化下拉显示树时，树选项的选中逻辑。

* fix demo

* fix. 静态下拉树时，出现错选的bug

* fix merge bugs.

* fix merge bugs.

* add. static dataObject Bind Support

* 将下拉树中，对偏平数据源的处理，移到simpleTreeSelect中

* fix ChildrenExpression

* feat: add dynamic component (#1703)

* feat: weakly-typed/dynamic component

* add TypeName support

* override BuildRenderTree instead of using a RenderFragment

* rename

* fix(module: timeline): label missing (#1941)

* chore: sync ant-design v4.16.13 (#1862)

Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: gmij <gmij@qq.com>
Co-authored-by: anranruye <hehewewe@hotmail.com>
Co-authored-by: Alan.Liu <lxyruanjian@126.com>
Co-authored-by: rabberbock <rabberbock@gmail.com>
Co-authored-by: Andrzej Bakun <anddrzejb@poczta.fm>
Co-authored-by: Chandan Rauniyar <chandankkrr@gmail.com>
Co-authored-by: Luke Parker [SSW] <10430890+Hona@users.noreply.github.com>
Co-authored-by: Tony Yip <tonyyip1969@gmail.com>
Co-authored-by: SmRiley <45205313+SmRiley@users.noreply.github.com>
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
@lukblazewicz
refactor(module: tree): rename Checked/Dechecked methods to Check/Unc…
47a9c87 
…heck (#1792)
ElderJames added a commit that referenced this pull request Sep 6, 2022
@ElderJames @lukblazewicz
@YongQuan-dotnet @anranruye @anddrzejb @zxyao145 @heroboy @SimonCropp @JohnHao421 @SapientGuardian @iamSmallY @stefanodriussi @Guyiming @CAPCHIK @nikolaykrondev @gmij @lxyruanjian @rabberbock @Chandankkrr @Hona @tonyyip1969 @SmRiley
Merge feature to master (#1945)
5d8ea2d 
* chore: sync ant-design v4.16.9 (#1782)

* refactor(module: tree): rename Checked/Dechecked methods to Check/Uncheck (#1792)

* feat(model: table): support responsive (#1802)

* feat(module: form): add properties Help, ValidateStatus and HasFeedback (#1807)

* Add properties Help, ValidateStatus and HasFeedback to FormItem

* refactor validation messages

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* feat(module: radio): add options for radio group (#1839)

* feat(module: radio): support enum type for `RadioGroup` (#1840)

* feat(module: image): support preview visible (#1842)

* feat(module: tree): add ChildContent for Tree and TreeNode (#1887)

* feat(module: tree): add ChildContent for Tree and TreeNode

Allow user set tree nodes directly.

* fix indent

* docs: Update the style to be compatible with antd 4.16 style. (#1893)

* docs: fix style

* fix logo font

* fix the color less

* feat(module: TreeSelect): add tree-select component 🚀 (#1773)

* fixed. Fix network error when requesting contributor list in local development environment

* fixed. Fix Chinese garbled code

* Update Dynamic.razor

* update. Adjust the base class of the select control to selectbase, and extract the common methods to prepare for tree select.

* fixed. Adjust the type of the parent control to selectbase

* tree-select完成基础编码工作。

* fix. 重新修订冲突解决时误删的变量

* fix. 修复在多选模式下无法显示初始值的bug

* fix some styles

* add. tree add Node UnSelect Event

* fix . Node Multiple Select Bug.

* fix Tree UnSelect invalid.

* fix. tree multiple select support.

* fix. select option sync tree node selected.

* fix. multiple select, old selected values has clear

* fix loop update exception

* 修复合并带来的冲突

* add. allow clear feat. but not finish.

* fix merge bug

* fix merge bug

* fix. supplementary notes

* update demo data with react demo

* add. 添加静态下拉树的能力，以及单选和多选的demo

* fix. 优化下拉显示树时，树选项的选中逻辑。

* fix demo

* fix. 静态下拉树时，出现错选的bug

* fix merge bugs.

* fix merge bugs.

* add. static dataObject Bind Support

* 将下拉树中，对偏平数据源的处理，移到simpleTreeSelect中

* fix ChildrenExpression

* feat: add dynamic component (#1703)

* feat: weakly-typed/dynamic component

* add TypeName support

* override BuildRenderTree instead of using a RenderFragment

* rename

* fix(module: timeline): label missing (#1941)

* chore: sync ant-design v4.16.13 (#1862)

Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: gmij <gmij@qq.com>
Co-authored-by: anranruye <hehewewe@hotmail.com>
Co-authored-by: Alan.Liu <lxyruanjian@126.com>
Co-authored-by: rabberbock <rabberbock@gmail.com>
Co-authored-by: Andrzej Bakun <anddrzejb@poczta.fm>
Co-authored-by: Chandan Rauniyar <chandankkrr@gmail.com>
Co-authored-by: Luke Parker [SSW] <10430890+Hona@users.noreply.github.com>
Co-authored-by: Tony Yip <tonyyip1969@gmail.com>
Co-authored-by: SmRiley <45205313+SmRiley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElderJames ElderJames ElderJames approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukblazewicz @ElderJames