Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AuthorizeReuseTabsRouteView #1910

Merged
merged 34 commits into from
Oct 11, 2021
Merged

Add AuthorizeReuseTabsRouteView #1910

merged 34 commits into from
Oct 11, 2021

Conversation

Guyiming
Copy link
Contributor

@Guyiming Guyiming commented Sep 3, 2021

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

💡 Background and solution

Make the ReuseTabsRouteView support Authentication

📝 Changelog

Language Changelog
🇺🇸 English A little difference usage with ReuseTabsRouteView is that the @Body is required in MainLayout.razor.
🇨🇳 Chinese ReuseTabsRouteView 使用上的区别是,为了执行一些跳转登录等操作,MainLayout.razor上的@Body必须要有。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #1910 (614b976) into master (6459e80) will increase coverage by 1.91%.
The diff coverage is 41.17%.

❗ Current head 614b976 differs from pull request most recent head e1f54e2. Consider uploading reports for the commit e1f54e2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1910      +/-   ##
==========================================
+ Coverage   25.38%   27.30%   +1.91%     
==========================================
  Files         488      511      +23     
  Lines       32098    24487    -7611     
  Branches        0      233     +233     
==========================================
- Hits         8148     6685    -1463     
+ Misses      23950    17766    -6184     
- Partials        0       36      +36     
Impacted Files Coverage Δ
components/tabs/Reuse/ReuseTabs.razor 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabs.razor.cs 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabsRouteView.cs 0.00% <0.00%> (ø)
components/tabs/TabPane.razor 86.66% <71.42%> (-6.20%) ⬇️
components/tabs/TabPane.razor.cs 69.44% <100.00%> (-0.56%) ⬇️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
... and 426 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6459e80...e1f54e2. Read the comment docs.

@Guyiming
Copy link
Contributor Author

Guyiming commented Sep 6, 2021

@ElderJames AuthorizeResuseTabsRouteView test demo added pls have a review.

@ElderJames ElderJames merged commit f30303e into ant-design-blazor:master Oct 11, 2021
ElderJames added a commit that referenced this pull request Oct 16, 2021
* 使MenItem同时支持Icon和IconFont,解决当使用iconfont.cn图标后,缩起内嵌菜单导致按钮样式不统一的问题。

* 空值判断

* add IconTemplate in MenuItem

* code format

* Add AuthorizeReuseTabsRouteView

* add readme.md

* remove comments

* Add AuthorizeResuseTabsRouteView test demo

* save

* save

* done

* refactor the test app

* fix test app

* debug

* debug

* fix tab render

* fix the copyright

* fix package infomation

* fix tab display order

* fix content focerender

Co-authored-by: BG345554 <ymgu@best-inc.com>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
@Guyiming Guyiming deleted the Add_AuthorizeReuseRouteView branch October 20, 2021 02:45
ElderJames added a commit that referenced this pull request Apr 23, 2022
* 使MenItem同时支持Icon和IconFont,解决当使用iconfont.cn图标后,缩起内嵌菜单导致按钮样式不统一的问题。

* 空值判断

* add IconTemplate in MenuItem

* code format

* Add AuthorizeReuseTabsRouteView

* add readme.md

* remove comments

* Add AuthorizeResuseTabsRouteView test demo

* save

* save

* done

* refactor the test app

* fix test app

* debug

* debug

* fix tab render

* fix the copyright

* fix package infomation

* fix tab display order

* fix content focerender

Co-authored-by: BG345554 <ymgu@best-inc.com>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* 使MenItem同时支持Icon和IconFont,解决当使用iconfont.cn图标后,缩起内嵌菜单导致按钮样式不统一的问题。

* 空值判断

* add IconTemplate in MenuItem

* code format

* Add AuthorizeReuseTabsRouteView

* add readme.md

* remove comments

* Add AuthorizeResuseTabsRouteView test demo

* save

* save

* done

* refactor the test app

* fix test app

* debug

* debug

* fix tab render

* fix the copyright

* fix package infomation

* fix tab display order

* fix content focerender

Co-authored-by: BG345554 <ymgu@best-inc.com>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Sep 6, 2022
* 使MenItem同时支持Icon和IconFont,解决当使用iconfont.cn图标后,缩起内嵌菜单导致按钮样式不统一的问题。

* 空值判断

* add IconTemplate in MenuItem

* code format

* Add AuthorizeReuseTabsRouteView

* add readme.md

* remove comments

* Add AuthorizeResuseTabsRouteView test demo

* save

* save

* done

* refactor the test app

* fix test app

* debug

* debug

* fix tab render

* fix the copyright

* fix package infomation

* fix tab display order

* fix content focerender

Co-authored-by: BG345554 <ymgu@best-inc.com>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants