fix(module:menu): Overlay bug fix & menu renering optimization #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark top menu as selected on init do not render non-active overlay submenus
nullable enabled for test project
|
|
Codecov Report
@@ Coverage Diff @@
## master #1949 +/- ##
==========================================
+ Coverage 23.92% 27.27% +3.35%
==========================================
Files 487 510 +23
Lines 31920 24346 -7574
Branches 0 229 +229
==========================================
- Hits 7636 6641 -995
+ Misses 24284 17669 -6615
- Partials 0 36 +36
Continue to review full report at Codecov.
|
anddrzejb
changed the title
ElderJames
pushed a commit
that referenced
this pull request
Oct 16, 2021
* fix(module:overlay): submenu causing crash * fix(module:overlay): submenu causing crash * fix(module:menu): show missing chevron mark top menu as selected on init do not render non-active overlay submenus * tests: common js mock extracted nullable enabled for test project * tests: menu * fix(module:menu): incorrect behavior in layout
anranruye
pushed a commit
to anranruye/ant-design-blazor
that referenced
this pull request
Nov 14, 2021
…design-blazor#1949) * fix(module:overlay): submenu causing crash * fix(module:overlay): submenu causing crash * fix(module:menu): show missing chevron mark top menu as selected on init do not render non-active overlay submenus * tests: common js mock extracted nullable enabled for test project * tests: menu * fix(module:menu): incorrect behavior in layout
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
* fix(module:overlay): submenu causing crash * fix(module:overlay): submenu causing crash * fix(module:menu): show missing chevron mark top menu as selected on init do not render non-active overlay submenus * tests: common js mock extracted nullable enabled for test project * tests: menu * fix(module:menu): incorrect behavior in layout
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
* fix(module:overlay): submenu causing crash * fix(module:overlay): submenu causing crash * fix(module:menu): show missing chevron mark top menu as selected on init do not render non-active overlay submenus * tests: common js mock extracted nullable enabled for test project * tests: menu * fix(module:menu): incorrect behavior in layout
ElderJames
pushed a commit
that referenced
this pull request
Sep 6, 2022
* fix(module:overlay): submenu causing crash * fix(module:overlay): submenu causing crash * fix(module:menu): show missing chevron mark top menu as selected on init do not render non-active overlay submenus * tests: common js mock extracted nullable enabled for test project * tests: menu * fix(module:menu): incorrect behavior in layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
Fixes #1644
💡 Background and solution
Overlaywas crashing when menu (as part of layout) was expanding with at least 1 submenu open. Solution - no need to render the submenu as overlay when layout menu is expanding. Extra - check onOverlayto prevent crash, with message to debugger.Missing chevron in submenus. Currently:
Expected:
Parent menu should be selected during initalization if any of its children is selected. Currently:
Expected:
Match css classes with antD.
Add tests for basic menu.
Optimize other tests & typescript scripts.
📝 Changelog
☑️ Self Check before Merge