fix(module:overlay): format number InvariantCulture #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cultures where decimal separator is ',' overlay would be ill-positioned Resolves ant-design-blazor#1955
|
|
|
|
|
Thanks for contribute this. |
Codecov Report
@@ Coverage Diff @@
## master #1956 +/- ##
==========================================
+ Coverage 25.44% 27.30% +1.85%
==========================================
Files 487 510 +23
Lines 31942 24359 -7583
Branches 0 233 +233
==========================================
- Hits 8129 6651 -1478
+ Misses 23813 17672 -6141
- Partials 0 36 +36
Continue to review full report at Codecov.
|
ElderJames
approved these changes
Sep 17, 2021
ElderJames
added a commit
that referenced
this pull request
Oct 16, 2021
In cultures where decimal separator is ',' overlay would be ill-positioned Resolves #1955 Co-authored-by: James Yeung <shunjiey@hotmail.com>
anranruye
pushed a commit
to anranruye/ant-design-blazor
that referenced
this pull request
Nov 14, 2021
…or#1956) In cultures where decimal separator is ',' overlay would be ill-positioned Resolves ant-design-blazor#1955 Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Apr 23, 2022
In cultures where decimal separator is ',' overlay would be ill-positioned Resolves #1955 Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Apr 30, 2022
In cultures where decimal separator is ',' overlay would be ill-positioned Resolves #1955 Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Sep 6, 2022
In cultures where decimal separator is ',' overlay would be ill-positioned Resolves #1955 Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cultures where decimal separator is ',' overlay would be ill-positioned
🤔 This is a ...
🔗 #1955
💡 Background and solution
If user has locale with ',' as decimal separator and the calculated left / top values have a decimal part the resulting formatted value will be not be parsable by browser:
📝 Changelog
☑️ Self Check before Merge