Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: grid): issue with gutter match due to breakpoint enum name case #1963

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fixed grid issue with gutter match due to breakpoint enum name case
🇨🇳 Chinese 修复 Grid 由于breakpoint枚举命名大小写导致breakpoint匹配的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 21, 2021

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #1963 (f8ece3c) into master (cb6efec) will increase coverage by 1.84%.
The diff coverage is 5.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1963      +/-   ##
==========================================
+ Coverage   25.43%   27.27%   +1.84%     
==========================================
  Files         487      510      +23     
  Lines       31955    24385    -7570     
  Branches        0      233     +233     
==========================================
- Hits         8129     6652    -1477     
+ Misses      23826    17697    -6129     
- Partials        0       36      +36     
Impacted Files Coverage Δ
components/descriptions/Descriptions.razor.cs 0.00% <0.00%> (ø)
components/grid/Row.razor.cs 0.00% <0.00%> (ø)
components/core/Extensions/EnumerableExtensions.cs 30.55% <25.00%> (-2.14%) ⬇️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/tabs/TabPane.razor 86.66% <0.00%> (-6.20%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
components/input/TextArea.razor.cs 77.52% <0.00%> (-3.05%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
... and 423 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6efec...f8ece3c. Read the comment docs.

@ElderJames ElderJames merged commit 6d9de1d into master Sep 22, 2021
@ElderJames ElderJames deleted the fix/grid-gutter-breakpointType branch September 22, 2021 14:08
ElderJames added a commit that referenced this pull request Oct 16, 2021
…e case (#1963)

* fix(module: grid):  issue with gutter match due to breakpoint enum name case

* add playground demo
anranruye pushed a commit to anranruye/ant-design-blazor that referenced this pull request Nov 14, 2021
…e case (ant-design-blazor#1963)

* fix(module: grid):  issue with gutter match due to breakpoint enum name case

* add playground demo
ElderJames added a commit that referenced this pull request Apr 23, 2022
…e case (#1963)

* fix(module: grid):  issue with gutter match due to breakpoint enum name case

* add playground de
ElderJames added a commit that referenced this pull request Apr 30, 2022
…e case (#1963)

* fix(module: grid):  issue with gutter match due to breakpoint enum name case

* add playground de
ElderJames added a commit that referenced this pull request Sep 6, 2022
…e case (#1963)

* fix(module: grid):  issue with gutter match due to breakpoint enum name case

* add playground de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant