refactor(module: tabs): improve rendering #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1970 +/- ##
==========================================
+ Coverage 25.39% 27.29% +1.90%
==========================================
Files 488 511 +23
Lines 32019 24485 -7534
Branches 0 233 +233
==========================================
- Hits 8130 6683 -1447
+ Misses 23889 17766 -6123
- Partials 0 36 +36
Continue to review full report at Codecov.
|
ElderJames
force-pushed
the
refactor/tabs
branch
from
493024f
to
51e5619
Compare
anranruye
approved these changes
Oct 8, 2021
This was referenced Oct 14, 2021
ElderJames
added a commit
that referenced
this pull request
Oct 16, 2021
* refactor(module: tabs): improve rendering * fix ForceRender & change constants to enums * fix animated * fix left extra content * add Centered feature * fix scroll distance * fix scroll gap * fix index out of range * fix tests * fix scroll distance * fix dropdown button position * fix ping left & right * hide the dropdown button
This was referenced Oct 21, 2021
ElderJames
added a commit
that referenced
this pull request
Apr 23, 2022
* refactor(module: tabs): improve rendering * fix ForceRender & change constants to enums * fix animated * fix left extra content * add Centered feature * fix scroll distance * fix scroll gap * fix index out of range * fix tests * fix scroll distance * fix dropdown button position * fix ping left & right * hide the dropdown button
ElderJames
added a commit
that referenced
this pull request
Apr 30, 2022
* refactor(module: tabs): improve rendering * fix ForceRender & change constants to enums * fix animated * fix left extra content * add Centered feature * fix scroll distance * fix scroll gap * fix index out of range * fix tests * fix scroll distance * fix dropdown button position * fix ping left & right * hide the dropdown button
ElderJames
added a commit
that referenced
this pull request
Sep 6, 2022
* refactor(module: tabs): improve rendering * fix ForceRender & change constants to enums * fix animated * fix left extra content * add Centered feature * fix scroll distance * fix scroll gap * fix index out of range * fix tests * fix scroll distance * fix dropdown button position * fix ping left & right * hide the dropdown button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
馃挕 Background and solution
tabsandtabpanein order to control the order of rendering in tabs, but this resulted in a Cartesian product of objects growing in number. Now we render thetabpanein ChildContnet directly, replacing only the tab's title when in drag and drop.馃摑 Changelog
鈽戯笍 Self Check before Merge