Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): fix selection #1973

Merged
merged 3 commits into from
Oct 10, 2021

Conversation

anranruye
Copy link
Member

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

  1. Fix can not select all, introduced by perf(module:table): improve table selection聽#1960
    In fact the items are selected, you can see that selectedRows already updated, but the table row ui is not updated

鍔ㄧ敾22

  1. Fix when change page index, backgroud of the selection box is updated before the table row

image

鍔ㄧ敾23

  1. Fix when change page index, the selected rows still exist, important for getting data from remote data source.
    鍔ㄧ敾24

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix when change page index, backgroud of the selection box is updated before the table row; Fix when change page index, the selected rows still exist
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 25, 2021

@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #1973 (9744897) into master (1f2a7f6) will increase coverage by 1.87%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1973      +/-   ##
==========================================
+ Coverage   25.39%   27.26%   +1.87%     
==========================================
  Files         488      511      +23     
  Lines       32019    24398    -7621     
  Branches        0      233     +233     
==========================================
- Hits         8130     6652    -1478     
+ Misses      23889    17710    -6179     
- Partials        0       36      +36     
Impacted Files Coverage 螖
components/table/Table.razor 0.00% <0.00%> (酶)
components/table/Table.razor.RowData.cs 0.00% <0.00%> (酶)
components/table/TableRow.razor 0.00% <0.00%> (酶)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) 猬囷笍
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) 猬囷笍
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) 猬囷笍
components/tabs/TabPane.razor 86.66% <0.00%> (-6.20%) 猬囷笍
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) 猬囷笍
components/input/TextArea.razor.cs 77.52% <0.00%> (-3.05%) 猬囷笍
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) 猬囷笍
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1f2a7f6...9744897. Read the comment docs.

@anranruye anranruye changed the title Fix table selection fix(module:table): fix selection Sep 25, 2021
@ElderJames ElderJames enabled auto-merge (squash) October 10, 2021 13:44
@ElderJames ElderJames merged commit bbcc890 into ant-design-blazor:master Oct 10, 2021
ElderJames pushed a commit that referenced this pull request Oct 16, 2021
* fix(module:table): can not select all

* fix(module:table): do not remain selection after change pageIndex

* Update table.razor
@anranruye anranruye deleted the FixTableSelection branch October 29, 2021 13:20
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
* fix(module:table): can not select all

* fix(module:table): do not remain selection after change pageIndex

* Update table.raz
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
* fix(module:table): can not select all

* fix(module:table): do not remain selection after change pageIndex

* Update table.raz
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
* fix(module:table): can not select all

* fix(module:table): do not remain selection after change pageIndex

* Update table.raz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants