fix(module: locale): fix custom locale resource #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1988 +/- ##
==========================================
+ Coverage 25.51% 27.43% +1.91%
==========================================
Files 488 511 +23
Lines 32111 24509 -7602
Branches 0 233 +233
==========================================
- Hits 8192 6723 -1469
+ Misses 23919 17750 -6169
- Partials 0 36 +36
Continue to review full report at Codecov.
|
ElderJames
reviewed
Oct 10, 2021
docs/i18n.en-US.md
Outdated
| @@ -28,11 +28,15 @@ By default, the current language is fetched from the browser. If you need to use | |||
|
|
|||
| ``` | |||
|
|
|||
| The default is set to "en-US" when the language you set does not have a built-in language pack. | |||
| You can also add it by using the 'LocaleProvider.SetLocale' method. | |||
| When the language you set does not have a built-in language pack, we will fallback to the parent `CultureInfo`, then `LocaleProvider.DefaultLanguage`, then "en-US". | |||
There was a problem hiding this comment.
It would be a good idea to add a link to the official documentation for parent CultureInfo.
ElderJames
approved these changes
Oct 12, 2021
ElderJames
pushed a commit
that referenced
this pull request
Oct 16, 2021
* fix(module: locale): fix custom locale resource * update doc * Update LocaleProvider,cs * Update i18n.zh-CN.md * Update LocaleProvider * Update docs
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
* fix(module: locale): fix custom locale resource * update doc * Update LocaleProvider,cs * Update i18n.zh-CN.md * Update LocaleProvider * Update docs
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
* fix(module: locale): fix custom locale resource * update doc * Update LocaleProvider,cs * Update i18n.zh-CN.md * Update LocaleProvider * Update docs
ElderJames
pushed a commit
that referenced
this pull request
Sep 6, 2022
* fix(module: locale): fix custom locale resource * update doc * Update LocaleProvider,cs * Update i18n.zh-CN.md * Update LocaleProvider * Update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
Fixes #1980
馃挕 Background and solution
Changes:
LocaleProvider.DefaultLanguageresource >en-US馃摑 Changelog
鈽戯笍 Self Check before Merge