-
-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:select): do not bring up keyboard when EnableSearch is false #1992
fix(module:select): do not bring up keyboard when EnableSearch is false #1992
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1992 +/- ##
==========================================
+ Coverage 25.39% 27.25% +1.86%
==========================================
Files 488 511 +23
Lines 32019 24405 -7614
Branches 0 233 +233
==========================================
- Hits 8130 6652 -1478
+ Misses 23889 17717 -6172
- Partials 0 36 +36
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found 1 problem related to this issue & 1 problem not directly related, but maybe you could fix it here as well:
First problem is self-explanatory I believe. Second problem - whole idea of tags
mode is to allow input (so users can enter new values that will be added). My feeling is that when in tags
mode, the EnableSelect
parameter should be set to true
when not set by users.
@anddrzejb the one in the image is a "multiple" mode Select, not "tag" mode. |
First is default, second is multiple and third is tags. |
So can the third one open the keyboard? And EnableSearch is a parameter property. I don't think we should modify it manually. Microsoft suggests that we should never change a parameter property manually and all parameter properties should be auto-implemented. Though sometimes we don't follow this design pattern, we should follow it as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thaks!
…lse (#1992) * fix(module:select): do not bring up keyboard when EnableSearch is false * Update SelectContent.razor * consider tags mode as searchEnabled
…lse (#1992) * fix(module:select): do not bring up keyboard when EnableSearch is false * Update SelectContent.razor * consider tags mode as searchEnabled
…lse (#1992) * fix(module:select): do not bring up keyboard when EnableSearch is false * Update SelectContent.razor * consider tags mode as searchEnabled
…lse (#1992) * fix(module:select): do not bring up keyboard when EnableSearch is false * Update SelectContent.razor * consider tags mode as searchEnabled
🤔 This is a ...
🔗 Related issue link
Fixes #1979
💡 Background and solution
📝 Changelog
Select
brings up keyboard on mobile devices☑️ Self Check before Merge