Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:antlist): react to changes to grid #2014

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

anddrzejb
Copy link
Member

@anddrzejb anddrzejb commented Oct 11, 2021

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixes #2000

💡 Background and solution

Added reaction to changes in Grid in the OnParametersSet() lifecycle method.
Also added tests, but they will start really working in net6. In net5 & before RenderFragments do not accept templates' context.
Fixed unrelated test that was failing in net6.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 11, 2021

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #2014 (f74512b) into master (f30303e) will increase coverage by 1.89%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
+ Coverage   25.51%   27.41%   +1.89%     
==========================================
  Files         488      511      +23     
  Lines       32111    24490    -7621     
  Branches        0      233     +233     
==========================================
- Hits         8192     6713    -1479     
+ Misses      23919    17741    -6178     
- Partials        0       36      +36     
Impacted Files Coverage Δ
components/list/AntList.razor.cs 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/tabs/TabPane.razor 86.66% <0.00%> (-6.20%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
components/input/TextArea.razor.cs 77.52% <0.00%> (-3.05%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Base/AntComponentBase.cs 46.42% <0.00%> (-2.96%) ⬇️
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) ⬇️
... and 422 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30303e...f74512b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamic change of grid attribute of AntList component is invalid
2 participants