Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:PropertyReflector): handle null value of propertyInfo #2025

Merged
merged 1 commit into from
Oct 20, 2021
Merged

fix(module:PropertyReflector): handle null value of propertyInfo #2025

merged 1 commit into from
Oct 20, 2021

Conversation

Guyiming
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

💡 Background and solution

image

When bind a Field (not Property) to control values, will prompt the following error:

bug

So, we need to handle the situation that the propertyInfo is null.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 14, 2021

@anddrzejb
Copy link
Member

@Guyiming I did not manage yet to go through your code, but does this PR try to solve #2011?

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #2025 (339efc0) into master (b459dcc) will increase coverage by 1.89%.
The diff coverage is 0.00%.

❗ Current head 339efc0 differs from pull request most recent head 037bda7. Consider uploading reports for the commit 037bda7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2025      +/-   ##
==========================================
+ Coverage   25.51%   27.40%   +1.89%     
==========================================
  Files         488      511      +23     
  Lines       32193    24538    -7655     
  Branches        0      238     +238     
==========================================
- Hits         8214     6725    -1489     
+ Misses      23979    17777    -6202     
- Partials        0       36      +36     
Impacted Files Coverage Δ
components/core/Reflection/PropertyReflector.cs 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/tabs/TabPane.razor 86.66% <0.00%> (-6.20%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
components/input/TextArea.razor.cs 77.52% <0.00%> (-3.05%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Base/AntComponentBase.cs 46.42% <0.00%> (-2.96%) ⬇️
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) ⬇️
... and 422 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b459dcc...037bda7. Read the comment docs.

@Guyiming
Copy link
Contributor Author

Guyiming commented Oct 14, 2021

@anddrzejb
yes

@ElderJames
Copy link
Member

Please rebase to master branch.

@ElderJames ElderJames linked an issue Oct 16, 2021 that may be closed by this pull request
@Guyiming
Copy link
Contributor Author

rebase done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controls fail to init when bound to fields and used inside FormItem
3 participants