fix(module:overlaytrigger): premature reset of _mouseInTrigger #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #2036 +/- ##
==========================================
+ Coverage 25.51% 27.40% +1.88%
==========================================
Files 488 511 +23
Lines 32189 24540 -7649
Branches 0 238 +238
==========================================
- Hits 8213 6725 -1488
+ Misses 23976 17779 -6197
- Partials 0 36 +36
Continue to review full report at Codecov.
|
ElderJames
approved these changes
Oct 18, 2021
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
ElderJames
pushed a commit
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fixes #2035
💡 Background and solution
PR #1977 had broken the
Popover. That PR added setting of_mouseInTrigger = truewhen trigger was clicked and then was setting it back to_mouseInTrigger = false. However, due to current way theOverlayTriggerworks, the_mouseInTriggeris set to 'true' much earlier (probably in js callback tomouseenterevent). I believe this is a both performance and design issue.OverlayTriggerregisters all the events (mouseenter,mouseleave,focus,blur,click,contextmenu) regardless of what will be the real trigger. I actually mentioned that in issue #1130. I already started working on that optimization, but it proved to be much more complex and it takes me much more time.I also tried to do a regression test, but I gave up. Not because it is impossible, but because this test is more complex than it is worth and it cannot provide 100% accuracy. For the test to be written in a reliable manner, the optimization has to be done (the one I mentioned in the paragraph above).
📝 Changelog
☑️ Self Check before Merge