Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix #1987 IsPicture bug #2049

Merged
merged 6 commits into from
Oct 27, 2021
Merged

Bug fix #1987 IsPicture bug #2049

merged 6 commits into from
Oct 27, 2021

Conversation

dashiell-zhang
Copy link
Member

@dnfadmin
Copy link

dnfadmin commented Oct 21, 2021 •
edited

CLA assistant check
All CLA requirements met.

@github-actions
Copy link

github-actions bot commented Oct 21, 2021 •
edited

@codecov
Copy link

codecov bot commented Oct 21, 2021 •
edited

Codecov Report

Merging #2049 (cf4335a) into master (46e2fc6) will increase coverage by 1.92%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2049      +/-   ##
==========================================
+ Coverage   25.76%   27.69%   +1.92%     
==========================================
  Files         489      512      +23     
  Lines       32243    24571    -7672     
  Branches        0      238     +238     
==========================================
- Hits         8309     6804    -1505     
+ Misses      23934    17731    -6203     
- Partials        0       36      +36
Impacted Files Coverage Δ
components/upload/UploadFileItem.cs 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/tabs/TabPane.razor 86.66% <0.00%> (-6.20%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
components/input/TextArea.razor.cs 77.52% <0.00%> (-3.05%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 45.71% <0.00%> (-1.91%) ⬇️
... and 423 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46e2fc6...cf4335a. Read the comment docs.

ElderJames
ElderJames approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ElderJames ElderJames merged commit 04e3475 into ant-design-blazor:master Oct 27, 2021
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
@dashiell-zhang
fix(module: upload): IsPicture bug (#2049)
26ac1ac 
* fix #1987 IsPicture bug

* Optimize image judgment method

* Optimize picture type Judgment method

* Optimize imagetypes comparison method
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
@dashiell-zhang
fix(module: upload): IsPicture bug (#2049)
61a6535 
* fix #1987 IsPicture bug

* Optimize image judgment method

* Optimize picture type Judgment method

* Optimize imagetypes comparison method
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
@dashiell-zhang
fix(module: upload): IsPicture bug (#2049)
5280e85 
* fix #1987 IsPicture bug

* Optimize image judgment method

* Optimize picture type Judgment method

* Optimize imagetypes comparison method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElderJames ElderJames ElderJames approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
3 participants
@dashiell-zhang @dnfadmin @ElderJames