Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): ReloadData() can't invoke OnChange #2071

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fixed ReloadData() can't invoke OnChange
🇨🇳 Chinese 修复 ReloadData() 不能触发 OnChange 的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 29, 2021

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #2071 (dca6f29) into master (e698e40) will increase coverage by 2.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2071      +/-   ##
==========================================
+ Coverage   27.57%   29.58%   +2.01%     
==========================================
  Files         489      513      +24     
  Lines       32243    24570    -7673     
  Branches        0      238     +238     
==========================================
- Hits         8890     7270    -1620     
+ Misses      23353    17264    -6089     
- Partials        0       36      +36     
Impacted Files Coverage Δ
components/table/Table.razor.cs 0.00% <0.00%> (ø)
components/table/TableModels/QueryModel.cs 0.00% <0.00%> (ø)
...omponents/table/TableModels/QueryableExtensions.cs 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/tabs/TabPane.razor 86.66% <0.00%> (-6.20%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
components/input/TextArea.razor.cs 77.52% <0.00%> (-3.05%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
... and 425 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e698e40...dca6f29. Read the comment docs.

@ElderJames ElderJames merged commit 9e40442 into master Oct 29, 2021
@ElderJames ElderJames deleted the fix/table-execute-query-model branch October 29, 2021 14:32
ElderJames added a commit that referenced this pull request Apr 23, 2022
* fix(module: table): optimized query API for EF

* fix table ReloadData() can't invoke OnChange
ElderJames added a commit that referenced this pull request Apr 30, 2022
* fix(module: table): optimized query API for EF

* fix table ReloadData() can't invoke OnChange
ElderJames added a commit that referenced this pull request Sep 6, 2022
* fix(module: table): optimized query API for EF

* fix table ReloadData() can't invoke OnChange
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants