Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: tabs): add context menu and page config for reusetabs #2075

Merged
merged 4 commits into from
Nov 3, 2021

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 30, 2021

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #2075 (285645f) into master (92d5c0d) will increase coverage by 1.98%.
The diff coverage is 40.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2075      +/-   ##
==========================================
+ Coverage   27.90%   29.88%   +1.98%     
==========================================
  Files         490      515      +25     
  Lines       32398    24731    -7667     
  Branches        0      240     +240     
==========================================
- Hits         9040     7391    -1649     
+ Misses      23358    17304    -6054     
- Partials        0       36      +36     
Impacted Files Coverage Δ
components/tabs/Reuse/ReuseTabs.razor 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabs.razor.cs 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabsPageAttribute.cs 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabsPageItem.cs 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabsRouteView.cs 0.00% <0.00%> (ø)
components/tabs/TabPane.razor 87.50% <60.00%> (-5.36%) ⬇️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 53.47% <100.00%> (+1.07%) ⬆️
components/locale-provider/Locale.cs 95.23% <100.00%> (+0.23%) ⬆️
components/tabs/Reuse/ReuseTabsLocale.cs 100.00% <100.00%> (ø)
components/tabs/TabPane.razor.cs 71.05% <100.00%> (-0.83%) ⬇️
... and 434 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d5c0d...285645f. Read the comment docs.

@ElderJames ElderJames merged commit 898f30b into master Nov 3, 2021
@ElderJames ElderJames deleted the feat/tabs-context-menu branch November 3, 2021 16:46
@YingXiaoMing
Copy link

too many Tabs in page show, can suppport overflow left and right

@ElderJames
Copy link
Member Author

@YingXiaoMing Let's improve it.

ElderJames added a commit that referenced this pull request Apr 23, 2022
…2075)

* feat(module: tabs): add context menu

* fix missing body

* remove icon

* add context menu de
ElderJames added a commit that referenced this pull request Apr 30, 2022
…2075)

* feat(module: tabs): add context menu

* fix missing body

* remove icon

* add context menu de
ElderJames added a commit that referenced this pull request Sep 6, 2022
…2075)

* feat(module: tabs): add context menu

* fix missing body

* remove icon

* add context menu de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants