Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:locale-provider): fix culture not found #2094

Merged

Conversation

anranruye
Copy link
Member

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Fixes #2059

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English fix: AntDesign.LocaleProvider type initializer throws CultureNotFoundException
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #2094 (166caee) into master (c81967d) will increase coverage by 1.92%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2094      +/-   ##
==========================================
+ Coverage   27.94%   29.87%   +1.92%     
==========================================
  Files         492      515      +23     
  Lines       32493    24746    -7747     
  Branches        0      240     +240     
==========================================
- Hits         9081     7392    -1689     
+ Misses      23412    17318    -6094     
- Partials        0       36      +36     
Impacted Files Coverage 螖
components/locale-provider/LocaleProvider.cs 54.54% <25.00%> (-7.96%) 猬囷笍
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) 猬囷笍
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) 猬囷笍
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) 猬囷笍
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) 猬囷笍
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) 猬囷笍
components/core/Component/Overlay/Overlay.razor.cs 65.89% <0.00%> (-2.86%) 猬囷笍
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) 猬囷笍
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 53.47% <0.00%> (-2.50%) 猬囷笍
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) 猬囷笍
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c81967d...166caee. Read the comment docs.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit a1d1c23 into ant-design-blazor:master Nov 10, 2021
@anranruye anranruye deleted the FixLocaleCultureNotFound branch December 18, 2021 16:01
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
* fix(module:locale-provider): fix culture-info not found

* Update fallback strategy
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
* fix(module:locale-provider): fix culture-info not found

* Update fallback strategy
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
* fix(module:locale-provider): fix culture-info not found

* Update fallback strategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The type initializer for 'AntDesign.LocaleProvider' threw an exception.
2 participants