fix(module: typography): Fix OnCopy
not invoked when Text
is null or empty
#2098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
When using
copyable
components inherittingTypographyBase
, such asAntDesign.Text
, if the value ofCopyConfig.Text
is null or empty, theOnCopy
action will be ignored. So developers cannot set self-defined content and inform the user of a message like 'Copied!' at the same time. And also the current doc/demo doesn't mention this, so I think it's a bug.The solution is to change the codes of
Copy
method.📝 Changelog
OnCopy
not invoked whenText
is null or emptyText
为null或空字符时OnCopy
未被执行的问题☑️ Self Check before Merge