Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: cascader): display indicator when options is null or empty #2108

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

noctis0430
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Nov 12, 2021

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #2108 (bb21336) into master (2cf5db5) will increase coverage by 1.94%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2108      +/-   ##
==========================================
+ Coverage   27.95%   29.89%   +1.94%     
==========================================
  Files         492      515      +23     
  Lines       32510    24762    -7748     
  Branches        0      240     +240     
==========================================
- Hits         9087     7403    -1684     
+ Misses      23423    17323    -6100     
- Partials        0       36      +36     
Impacted Files Coverage Δ
components/cascader/Cascader.razor.cs 22.28% <0.00%> (+4.44%) ⬆️
components/cascader/Cascader.razor 83.22% <83.33%> (+9.31%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Component/Overlay/Overlay.razor.cs 65.89% <0.00%> (-2.86%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 53.47% <0.00%> (-2.50%) ⬇️
... and 425 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf5db5...bb21336. Read the comment docs.

@ElderJames
Copy link
Member

I also found the clear button an issue. You can fix it in this PR, or you can open another one.
cascader-clear-button

@noctis0430
Copy link
Contributor Author

I also found the clear button an issue. You can fix it in this PR, or you can open another one. cascader-clear-button

Ok. Will try to fix it in this PR.

@noctis0430
Copy link
Contributor Author

I also found the clear button an issue. You can fix it in this PR, or you can open another one.

Just found out the clear button issue is a separated issue. Maybe we should close this and open another one for it. @ElderJames what do you think?

@noctis0430
Copy link
Contributor Author

I also just found out that there's an existing default image to indicate empty options.

Default image

Image in <Empty/> introduced in this PR

For the sake of consistency, we should pick and use only one. Which should we choose?

@ElderJames
Copy link
Member

This one.

@noctis0430 noctis0430 changed the title feat(module: cascader): display Empty component when options is null or empty feat(module: cascader): display indicator when options is null or empty Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants