Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error width for disable body scroll #2163

Merged
merged 5 commits into from
Dec 14, 2021

Conversation

zxyao145
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2102

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: error width for disable body scroll
🇨🇳 Chinese 修复禁用body滚动条时宽度设置的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Dec 11, 2021

@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #2163 (5853db0) into master (8f89deb) will increase coverage by 1.81%.
The diff coverage is 34.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2163      +/-   ##
==========================================
+ Coverage   27.86%   29.68%   +1.81%     
==========================================
  Files         492      519      +27     
  Lines       32544    25341    -7203     
  Branches        0      247     +247     
==========================================
- Hits         9070     7523    -1547     
+ Misses      23474    17778    -5696     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/date-picker/RangePicker.razor.cs 0.00% <0.00%> (ø)
components/input/Input.cs 67.61% <ø> (+4.64%) ⬆️
components/transfer/Transfer.razor 0.00% <0.00%> (ø)
components/tree-select/TreeSelect.razor.cs 0.00% <0.00%> (ø)
...s/core/JsInterop/modules/dom/manipulationHelper.ts 15.03% <12.50%> (ø)
components/core/Base/AntInputComponentBase.cs 61.46% <37.03%> (+5.17%) ⬆️
components/form/FormItem.razor.cs 42.38% <72.72%> (+4.58%) ⬆️
components/select/Select.razor.cs 52.80% <100.00%> (+2.23%) ⬆️
components/select/SelectBase.cs 71.11% <100.00%> (+5.49%) ⬆️
tests/AntDesign.Tests.Js/tests/domInit.ts 86.95% <100.00%> (ø)
... and 456 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa200f9...5853db0. Read the comment docs.

@ElderJames ElderJames merged commit 5986011 into ant-design-blazor:master Dec 14, 2021
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
* fix: error width for disableBodyScroll

* test: add some test for manipulationHelper

* test: unit test ifx

* fix: code format

* chore: code format
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
* fix: error width for disableBodyScroll

* test: add some test for manipulationHelper

* test: unit test ifx

* fix: code format

* chore: code format
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
* fix: error width for disableBodyScroll

* test: add some test for manipulationHelper

* test: unit test ifx

* fix: code format

* chore: code format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants