Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if CanDraggable, missed MatchedClass and error if TreeComponent.Searc… #2171

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

jp-rl
Copy link
Contributor

@jp-rl jp-rl commented Dec 15, 2021

Hi,

This is a bug fix for TreeNodeTitle.razor. It's possible there is/are any more bug because Razor code inside in CanDraggable and else is not the same

regards

@dnfadmin
Copy link

dnfadmin commented Dec 15, 2021

CLA assistant check
All CLA requirements met.

@github-actions
Copy link

github-actions bot commented Dec 15, 2021

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #2171 (7d2a31a) into master (0362659) will increase coverage by 1.94%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2171      +/-   ##
==========================================
+ Coverage   27.84%   29.78%   +1.94%     
==========================================
  Files         496      519      +23     
  Lines       33074    25357    -7717     
  Branches        0      247     +247     
==========================================
- Hits         9210     7553    -1657     
+ Misses      23864    17764    -6100     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/tree/TreeNodeTitle.razor 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) ⬇️
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) ⬇️
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) ⬇️
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0362659...7d2a31a. Read the comment docs.

@ElderJames ElderJames merged commit 666788e into ant-design-blazor:master Dec 17, 2021
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants