Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: checkbox): value binding for checkbox group #2173

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2169

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix value binding for checkbox group
🇨🇳 Chinese 修复 CheckboxGroup 绑定 Value 的变量不能修改选中框的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Dec 16, 2021

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #2173 (6c8c83b) into master (cb04e17) will increase coverage by 1.98%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2173      +/-   ##
==========================================
+ Coverage   27.73%   29.71%   +1.98%     
==========================================
  Files         496      519      +23     
  Lines       33051    25357    -7694     
  Branches        0      247     +247     
==========================================
- Hits         9167     7536    -1631     
+ Misses      23884    17781    -6103     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/checkbox/CheckboxGroup.razor.cs 86.86% <76.47%> (+0.27%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) ⬇️
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) ⬇️
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) ⬇️
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb04e17...6c8c83b. Read the comment docs.

@ElderJames ElderJames merged commit 0362659 into master Dec 16, 2021
@ElderJames ElderJames deleted the fix/chexkbox-group-binding branch December 16, 2021 10:59
ElderJames added a commit that referenced this pull request Apr 23, 2022
* fix(module: checkbox): value binding for checkbox group
ElderJames added a commit that referenced this pull request Apr 30, 2022
* fix(module: checkbox): value binding for checkbox group
ElderJames added a commit that referenced this pull request Sep 6, 2022
* fix(module: checkbox): value binding for checkbox group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CheckboxGroup Value data is not two-way bound
1 participant