New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module: modal): get rtl from ConfigProvider #2295
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2295 +/- ##
==========================================
+ Coverage 27.73% 29.75% +2.01%
==========================================
Files 496 519 +23
Lines 33104 25374 -7730
Branches 0 247 +247
==========================================
- Hits 9181 7549 -1632
+ Misses 23923 17785 -6138
- Partials 0 40 +40
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit solves the overlapping title and close button in Rtl mode. I've tested this change on local source.
馃 This is a ...
馃敆 Related issue link
#2288
馃挕 Background and solution
馃摑 Changelog
鈽戯笍 Self Check before Merge