Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: modal): get rtl from ConfigProvider #2295

Merged
merged 1 commit into from Feb 16, 2022

Conversation

zxyao145
Copy link
Member

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#2288

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English fix(module: modal): get rtl from ConfigProvider
馃嚚馃嚦 Chinese Modal锛氫粠ConfigProvider鑾峰彇Rtl

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Feb 15, 2022

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #2295 (e728c5c) into master (fa59e95) will increase coverage by 2.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2295      +/-   ##
==========================================
+ Coverage   27.73%   29.75%   +2.01%     
==========================================
  Files         496      519      +23     
  Lines       33104    25374    -7730     
  Branches        0      247     +247     
==========================================
- Hits         9181     7549    -1632     
+ Misses      23923    17785    -6138     
- Partials        0       40      +40     
Impacted Files Coverage 螖
components/modal/modalDialog/Modal.razor.cs 0.00% <0.00%> (酶)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) 猬囷笍
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) 猬囷笍
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) 猬囷笍
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) 猬囷笍
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) 猬囷笍
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) 猬囷笍
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) 猬囷笍
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) 猬囷笍
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) 猬囷笍
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fa59e95...e728c5c. Read the comment docs.

Copy link

@hassan-gasemi hassan-gasemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit solves the overlapping title and close button in Rtl mode. I've tested this change on local source.

@ElderJames ElderJames merged commit 1ccad40 into ant-design-blazor:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants