Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if HidePagination is true,set PagSize value is DataSource Count #2476

Merged
merged 5 commits into from
Nov 8, 2022

Conversation

CareyYang
Copy link
Contributor

@CareyYang CareyYang commented May 25, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented May 25, 2022

@CareyYang CareyYang closed this May 26, 2022
@michaelcsikos
Copy link

Has this been merged in yet? I currently have to set the PageSize explicitly with HidePagination.

@ElderJames ElderJames reopened this Nov 8, 2022
@ElderJames
Copy link
Member

@michaelcsikos I would reopen and merge this PR.

Change set PageSize Method when HidePagination is true.

if HidePagination is true,set PagSize value is DataSource Count

if HidePagination is true,set PagSize value is DataSource Count

if HidePagination is true,set PagSize value is DataSource Count
@ElderJames ElderJames changed the base branch from feature to master November 8, 2022 03:01
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 42.78% // Head: 44.22% // Increases project coverage by +1.44% 🎉

Coverage data is based on head (cbf5619) compared to base (6c8d71f).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head cbf5619 differs from pull request most recent head c2f4a4d. Consider uploading reports for the commit c2f4a4d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2476      +/-   ##
==========================================
+ Coverage   42.78%   44.22%   +1.44%     
==========================================
  Files         545      545              
  Lines       25775    25773       -2     
  Branches      261      261              
==========================================
+ Hits        11027    11399     +372     
+ Misses      14708    14334     -374     
  Partials       40       40              
Impacted Files Coverage Δ
components/table/Table.razor.cs 0.00% <0.00%> (ø)
components/select/Select.razor.cs 53.18% <0.00%> (+0.26%) ⬆️
components/select/SelectBase.cs 71.19% <0.00%> (+0.27%) ⬆️
components/input/Input.cs 67.25% <0.00%> (+0.35%) ⬆️
components/date-picker/internal/DatePickerBase.cs 78.87% <0.00%> (+0.67%) ⬆️
components/core/CssSizeLength.cs 86.07% <0.00%> (+1.07%) ⬆️
components/grid/Col.razor.cs 96.00% <0.00%> (+1.33%) ⬆️
components/drawer/Drawer.razor.cs 93.46% <0.00%> (+3.26%) ⬆️
components/core/Extensions/JSRuntimeExtensions.cs 53.33% <0.00%> (+3.33%) ⬆️
components/grid/Row.razor.cs 84.44% <0.00%> (+8.88%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames merged commit 97fcd5b into ant-design-blazor:master Nov 8, 2022
@CareyYang CareyYang deleted the feature branch November 11, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants