-
-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:datepicker): Scroll to selected time in DatePicker/TimePicker #2512
feat(module:datepicker): Scroll to selected time in DatePicker/TimePicker #2512
Conversation
Hey @ElderJames. I've implemented auto-scroll behavior similar to the one in ant.design. It may need a smoother animation when the selection panel (overlay) is open, but it generally works okay. Please check and let me know what you think. |
Codecov Report
@@ Coverage Diff @@
## feature #2512 +/- ##
===========================================
+ Coverage 27.68% 29.37% +1.68%
===========================================
Files 498 535 +37
Lines 33526 25948 -7578
Branches 0 260 +260
===========================================
- Hits 9283 7621 -1662
+ Misses 24243 18287 -5956
- Partials 0 40 +40
Continue to review full report at Codecov.
|
There are other issues with manual input.
|
I've tried changing it to accept parsed value immediately 9211cf8, but in this case, a unit test fails. So what behavior do we want here? Should it apply the value of manual input with Enter key and Ok button only? But in this case, why is the input from the panel confirmed immediately? 🤔 In the ant.design the input is applied only after Enter key or Ok button. |
…nput" This reverts commit 9211cf8.
Maybe we can follow the behavior of ant.design |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
…icker (#2512) * feat(module: datetimepicker): scroll to selected time * refactor(module: datepicker): move scroll to code behind * fix(module: datetimepicker): no scroll to selected time on manual input * fix(module: datetimepicker): 12-hour time is not parsed on manual input * fix(module: datetimepicker): entered time ignored on manual input * feat(module: datepicker): add animation to time picker * Revert "fix(module: datetimepicker): entered time ignored on manual input" This reverts commit 9211cf8. * refactor(module: datepicker): cleanup redundant code * refactor(module: datepicker): reduce size of animation function * fix(module: datepicker):duplicate calls to StateHasChanged on date hove
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge