Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icon): two-tone color icon implements #2513

Merged
merged 11 commits into from Jun 18, 2022
Merged

feat(icon): two-tone color icon implements #2513

merged 11 commits into from Jun 18, 2022

Conversation

rqx110
Copy link
Contributor

@rqx110 rqx110 commented Jun 12, 2022 •
edited

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

resolve #1600

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English two-tone color icon implements
馃嚚馃嚦 Chinese 瀹炵幇鍙岃壊鍥炬爣

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jun 12, 2022 •
edited

@rqx110
Copy link
Contributor Author

rqx110 commented Jun 12, 2022

鎴睆2022-06-12 10 59 14

@ElderJames
Copy link
Member

@rqx110 Excellent! Thank you so much!

@codecov
Copy link

codecov bot commented Jun 12, 2022 •
edited

Codecov Report

Merging #2513 (f0241a3) into feature (acb6c89) will increase coverage by 1.62%.
The diff coverage is 44.68%.

@@             Coverage Diff             @@
##           feature    #2513      +/-   ##
===========================================
+ Coverage    27.68%   29.31%   +1.62%     
===========================================
  Files          498      535      +37     
  Lines        33526    25973    -7553     
  Branches         0      260     +260     
===========================================
- Hits          9283     7613    -1670     
+ Misses       24243    18320    -5923     
- Partials         0       40      +40
Impacted Files Coverage 螖
components/core/JsInterop/JSInteropConstants.cs 28.09% <0.00%> (-0.72%) 猬囷笍
components/core/JsInterop/interop.ts 0.00% <酶> (酶)
...ts/core/JsInterop/modules/components/iconHelper.ts 0.00% <0.00%> (酶)
components/icon/IconFont.razor.cs 0.00% <0.00%> (酶)
components/icon/IconService.cs 33.33% <0.00%> (-22.55%) 猬囷笍
components/icon/Icon.razor.cs 85.71% <74.07%> (-0.50%) 猬囷笍
components/icon/Icon.razor 75.00% <100.00%> (+12.50%) 猬嗭笍
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) 猬囷笍
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) 猬囷笍
components/date-picker/locale/FormatAnalyzer.cs 90.59% <0.00%> (-7.33%) 猬囷笍
... and 447 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update acb6c89...f0241a3. Read the comment docs.

@ElderJames ElderJames changed the base branch from master to feature June 12, 2022 10:31
@rqx110
Copy link
Contributor Author

rqx110 commented Jun 13, 2022 •
edited

I can't run the project successfully, after changed the base branch from master to feature.

image

also when I run it using dotnet6, not woking well.

build error will be fixed in #2514

@rqx110
Copy link
Contributor Author

rqx110 commented Jun 17, 2022

Note

  1. the flash problem already exist:
    ff1

  2. if we remove the OnParametersSetAsync function, it will not change color in runtime:
    ff2

@ElderJames
Copy link
Member

@rqx110 Thanks for check. How about the last commit?

@rqx110
Copy link
Contributor Author

rqx110 commented Jun 17, 2022

@rqx110 Thanks for check. How about the last commit?

last commit is same result of above comment.

I think we can't fix the flash problem(show grey then colored quickly) currently.
but we need allow to change the color on runtime!

@ElderJames ElderJames merged commit a962626 into ant-design-blazor:feature Jun 18, 2022
@pr-triage pr-triage bot added the PR: merged label Jun 18, 2022
@ElderJames ElderJames mentioned this pull request Jun 30, 2022
Closed
ElderJames added a commit that referenced this pull request Sep 6, 2022
@rqx110 @ElderJames
feat(module: icon): implement two-tone color icon (#2513)
f95a033 
* feat(icon): two-tone color icon implements

* generate secondary color from js, and generate icon from C#

* remove unused code

* render the icons in the prerendering stage

* render the icons in the prerendering stage

* fixed multiple renders

* refactor iconfont

* remove should render flag

* fix color change

* add AvoidPrerendering

Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElderJames ElderJames ElderJames approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It seems two tone color icon is not working
2 participants
@rqx110 @ElderJames