Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix icon demo exception when prerendering #2527

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jun 19, 2022

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #2527 (2c8fd5c) into master (a590d93) will increase coverage by 1.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2527      +/-   ##
==========================================
+ Coverage   27.71%   29.66%   +1.94%     
==========================================
  Files         497      520      +23     
  Lines       33433    25623    -7810     
  Branches        0      250     +250     
==========================================
- Hits         9265     7600    -1665     
+ Misses      24168    17983    -6185     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) ⬇️
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) ⬇️
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) ⬇️
components/core/Helpers/THelper.cs 36.00% <0.00%> (-1.78%) ⬇️
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a590d93...2c8fd5c. Read the comment docs.

@ElderJames ElderJames merged commit 5726958 into master Jun 19, 2022
@ElderJames ElderJames deleted the docs/fix-icon-demo-prerendering branch June 19, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant