Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: input-number): add PlaceHolder parameter #2528

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

ElderJames
Copy link
Member

@ElderJames ElderJames commented Jun 19, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2526

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add PlaceHolder parameter
🇨🇳 Chinese 增加 PlaceHolder 属性

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jun 19, 2022

@ElderJames ElderJames linked an issue Jun 19, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #2528 (31a45a0) into feature (a962626) will increase coverage by 1.69%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           feature    #2528      +/-   ##
===========================================
+ Coverage    27.62%   29.31%   +1.69%     
===========================================
  Files          498      535      +37     
  Lines        33685    25975    -7710     
  Branches         0      260     +260     
===========================================
- Hits          9305     7615    -1690     
+ Misses       24380    18320    -6060     
- Partials         0       40      +40     
Impacted Files Coverage Δ
components/input-number/InputNumber.razor 100.00% <100.00%> (ø)
components/input-number/InputNumber.razor.cs 56.40% <100.00%> (+5.78%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 52.91% <0.00%> (-2.69%) ⬇️
components/core/Component/Overlay/Overlay.razor.cs 66.86% <0.00%> (-2.52%) ⬇️
... and 441 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a962626...31a45a0. Read the comment docs.

@ElderJames ElderJames merged commit 3df40f2 into feature Jun 19, 2022
@ElderJames ElderJames deleted the feat/input-number-palceholder branch June 19, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputNumber suppert Placeholder
1 participant