-
-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/date picker ok button #2531
fix/date picker ok button #2531
Conversation
Codecov Report
@@ Coverage Diff @@
## feature #2531 +/- ##
===========================================
+ Coverage 27.62% 29.34% +1.72%
===========================================
Files 498 536 +38
Lines 33688 26018 -7670
Branches 0 260 +260
===========================================
- Hits 9305 7636 -1669
+ Misses 24383 18342 -6041
- Partials 0 40 +40
Continue to review full report at Codecov.
|
Hey @ElderJames I have a question regarding the unit test below. The code it covers prevents manually entered values from being applied. So when you manually enter a time value for example it always reverted back. Why? ant-design-blazor/tests/AntDesign.Tests/DatePicker/DatePickerKeyboardInputTests.razor Lines 30 to 49 in 5726958
The code it covers ant-design-blazor/components/date-picker/DatePicker.Razor.cs Lines 89 to 138 in 5726958
I believe it should only be reverted when parsing fails and if this is not the case the |
Hi @Alexbits , I agree with you. |
…ue (#2531) * fix(module: datepicker): Ok button does not confirm selected time value * fix(module: datepicker): value stays in the input after clear clicked * fix(module: datepicker): suffix icon click does not open input panel * fix(module: datepicker): manual input reverted on blur * fix(module: datepicker): wrong behavior when Open is set to true
🤔 This is a ...
🔗 Related issue link
#2496
#2481
#2441
#1990
💡 Background and solution
This PR Makes Ok button behavior closer to the ant.design
📝 Changelog
☑️ Self Check before Merge