Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: layout): add two-way binding for Collapsed parameter #2536

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2524

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Sider 增加 Collapsed 属性双向绑定
🇨🇳 Chinese add two-way binding for Collapsed parameter

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jun 22, 2022

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #2536 (faaef11) into master (5726958) will increase coverage by 1.95%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2536      +/-   ##
==========================================
+ Coverage   27.63%   29.58%   +1.95%     
==========================================
  Files         497      520      +23     
  Lines       33433    25628    -7805     
  Branches        0      250     +250     
==========================================
- Hits         9239     7583    -1656     
+ Misses      24194    18005    -6189     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/layout/Sider.razor.cs 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) ⬇️
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) ⬇️
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) ⬇️
... and 425 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5726958...faaef11. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Layout] Display width change does not trigger Fixed Sider's collapsed value
1 participant