Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module: reusetabs): support pinned tabs #2545

Merged
merged 4 commits into from
Aug 6, 2022
Merged

feat(module: reusetabs): support pinned tabs #2545

merged 4 commits into from
Aug 6, 2022

Conversation

hzy-6
Copy link
Contributor

@hzy-6 hzy-6 commented Jun 29, 2022 •
edited by ElderJames

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@dnfadmin
Copy link

dnfadmin commented Jun 29, 2022 •
edited

CLA assistant check
All CLA requirements met.

@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited

@hzy-6 hzy-6 changed the base branch from master to feature June 29, 2022 09:17
@codecov
Copy link

codecov bot commented Jun 29, 2022 •
edited

Codecov Report

Merging #2545 (29212e8) into feature (e892f34) will increase coverage by 3.40%.
The diff coverage is 1.33%.

@@             Coverage Diff             @@
##           feature    #2545      +/-   ##
===========================================
+ Coverage    27.46%   30.86%   +3.40%     
===========================================
  Files          503      542      +39     
  Lines        33884    26344    -7540     
  Branches         0      260     +260     
===========================================
- Hits          9305     8131    -1174     
+ Misses       24579    18173    -6406     
- Partials         0       40      +40
Impacted Files Coverage Δ
components/tabs/Reuse/ReuseTabs.razor 0.00% <ø> (ø)
components/tabs/Reuse/ReuseTabs.razor.cs 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabsPageAttribute.cs 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabsPageItem.cs 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabsRouteView.cs 0.00% <0.00%> (ø)
components/tabs/Reuse/ReuseTabsService.cs 0.00% <0.00%> (ø)
...nts/core/Extensions/ServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
... and 453 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames changed the title 完善 ReuseTabs feat(module: reusetabs): support fixed tab Jul 26, 2022
@ElderJames ElderJames changed the title feat(module: reusetabs): support fixed tab feat(module: reusetabs): support pinned tabs Aug 6, 2022
@ElderJames ElderJames merged commit 5d127bf into ant-design-blazor:feature Aug 6, 2022
ElderJames added a commit that referenced this pull request Sep 6, 2022
@hzy-6 @ElderJames
feat(module: tabs): ReuseTabs support pinning tabs (#2545)
2d81d98 
* 选项卡添加永久显示选项功能

* 解决选项卡长久停留选项，目前还存在排序问题

* 完善永久停留标签，添加 ReuseTabsService 服务

* refactor

Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hzy-6 @dnfadmin @ElderJames