Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and create test to value display when step value notation is scientific #2547

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Conversation

petertorocsik
Copy link
Contributor

@petertorocsik petertorocsik commented Jun 29, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@dnfadmin
Copy link

dnfadmin commented Jun 29, 2022

CLA assistant check
All CLA requirements met.

@github-actions
Copy link

github-actions bot commented Jun 29, 2022

Prepare preview

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #2547 (6f38a91) into master (bf62fac) will increase coverage by 2.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2547      +/-   ##
==========================================
+ Coverage   27.70%   29.73%   +2.03%     
==========================================
  Files         497      520      +23     
  Lines       33445    25631    -7814     
  Branches        0      250     +250     
==========================================
- Hits         9265     7622    -1643     
+ Misses      24180    17969    -6211     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/input-number/InputNumber.razor.cs 64.91% <100.00%> (+14.30%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) ⬇️
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) ⬇️
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) ⬇️
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf62fac...6f38a91. Read the comment docs.

@ElderJames ElderJames merged commit d03fe7a into ant-design-blazor:master Jul 14, 2022
ElderJames added a commit that referenced this pull request Sep 6, 2022
…is scientific (#2547)

* InputNumber value display correction with test when step value notation is scientific

* fix NumberFormatInfo of ToString()

Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants