-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module: datepicker): value not updated when changed programmatically #2551
fix(module: datepicker): value not updated when changed programmatically #2551
Conversation
This PR should fix the issue with |
Codecov Report
@@ Coverage Diff @@
## feature #2551 +/- ##
===========================================
+ Coverage 27.34% 29.64% +2.30%
===========================================
Files 503 541 +38
Lines 33956 26150 -7806
Branches 0 260 +260
===========================================
- Hits 9284 7752 -1532
+ Misses 24672 18358 -6314
- Partials 0 40 +40
Continue to review full report at Codecov.
|
Thanks @Alexbits , maybe this PR can be target to branch master. |
I wanted to commit |
That's fine. Just let it stay at feature. |
Yes, I found this. I take it you haven't fixed the bug yet. |
Hey @ElderJames I fixed it in the last commit. |
…lly (#2551) * fix(module: datepicker): value not updated when changed programmatically * fix(module: rangepicker): value not updated when set programmatically * fix:(module: datepicker): placeholder attribute not applied to input * fix:(module: rangepicker): end date placeholder is not cleared
🤔 This is a ...
🔗 Related issue link
#2538
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge