Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: modal): unreset enter animation className #2561

Conversation

zxyao145
Copy link
Member

@zxyao145 zxyao145 commented Jul 8, 2022

🤔 This is a ...

#2558

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English reset enter animation className
🇨🇳 Chinese 重置modal打开时候的动画

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #2561 (aa8c03f) into master (08e8956) will increase coverage by 1.94%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2561      +/-   ##
==========================================
+ Coverage   27.70%   29.64%   +1.94%     
==========================================
  Files         497      520      +23     
  Lines       33442    25635    -7807     
  Branches        0      250     +250     
==========================================
- Hits         9265     7600    -1665     
+ Misses      24177    17995    -6182     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/modal/core/Dialog.razor.cs 0.00% <0.00%> (ø)
components/modal/core/DialogWrapper.razor.cs 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) ⬇️
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) ⬇️
... and 426 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e8956...aa8c03f. Read the comment docs.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants