Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a draggable list item demo #2563

Merged
merged 1 commit into from
Jul 14, 2022
Merged

add a draggable list item demo #2563

merged 1 commit into from
Jul 14, 2022

Conversation

charset
Copy link
Contributor

@charset charset commented Jul 11, 2022

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃挕 Background and solution

By adding a div element in ListItem and setting draggable='true' and providing some ondragover/ondragstart/ondrop envent handlers to simple list making the list items can be dragged and dropped to arrange the list sequence.

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided
  • Demo is updated/provided
  • Changelog is not needed

@github-actions
Copy link

github-actions bot commented Jul 11, 2022

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #2563 (164ed73) into master (a935863) will increase coverage by 2.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2563      +/-   ##
==========================================
+ Coverage   27.62%   29.64%   +2.02%     
==========================================
  Files         497      520      +23     
  Lines       33450    25635    -7815     
  Branches        0      250     +250     
==========================================
- Hits         9239     7600    -1639     
+ Misses      24211    17995    -6216     
- Partials        0       40      +40     
Impacted Files Coverage 螖
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) 猬囷笍
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) 猬囷笍
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) 猬囷笍
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) 猬囷笍
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) 猬囷笍
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) 猬囷笍
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) 猬囷笍
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) 猬囷笍
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) 猬囷笍
components/core/Helpers/THelper.cs 36.00% <0.00%> (-1.78%) 猬囷笍
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a935863...164ed73. Read the comment docs.

@ElderJames ElderJames merged commit 0f14c99 into ant-design-blazor:master Jul 14, 2022
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
Co-authored-by: 鍚村潥 CHARSET <lemongrasstea@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants