feat(module: tooltip): enable setting TabIndex via parameter #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #2567 +/- ##
==========================================
+ Coverage 27.70% 29.58% +1.88%
==========================================
Files 497 520 +23
Lines 33445 25631 -7814
Branches 0 250 +250
==========================================
- Hits 9265 7583 -1682
+ Misses 24180 18008 -6172
- Partials 0 40 +40
Continue to review full report at Codecov.
|
ElderJames
pushed a commit
that referenced
this pull request
Sep 6, 2022
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#2566
💡 Background and solution
In the current shape, tooltip component is stealing focus (when user is jumping through elements on the page using Tab key) even if children elements of the tooltip have
tabindexset to-1. Enabling customization of tooltip's tabindex via parameter allows developer to alter this behavior if needed. The default behavior (tabindex="0") required for proper functioning of the focus trigger (#2404) remains the same, so we are on the safe side - it's up to the user to consciously opt-out.📝 Changelog
☑️ Self Check before Merge