Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(module:rangepicker): date selection #2570

Merged

Conversation

Alexbits
Copy link
Contributor

@Alexbits Alexbits commented Jul 16, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#1429

💡 Background and solution

Fixes quarter/week range selection when the end value is set first.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 16, 2022

@Alexbits Alexbits changed the base branch from master to feature July 16, 2022 08:39
@Alexbits Alexbits changed the title fix/range picker date selection fix:(module:rangepicker): date selection Jul 16, 2022
@ElderJames
Copy link
Member

I found another issue that time out of range is not disabled.

image

@Alexbits
Copy link
Contributor Author

Alexbits commented Jul 24, 2022

I found another issue that time out of range is not disabled.

In the ant.design the time input is not disabled. Instead, the values change their places when the start value is later than the end value or vice versa. I already implemented the behavior when hours, minutes, and seconds in the time input get disabled, and then I checked out the original ant.design and IDK now 🤷‍♂️ I've committed the change. Check it out @ElderJames

I found another bug where the keyboard input allows to enter the later value as the start of the range. Fixed in the last commit.

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #2570 (d0d2074) into feature (c00dd6f) will increase coverage by 3.06%.
The diff coverage is 70.49%.

@@             Coverage Diff             @@
##           feature    #2570      +/-   ##
===========================================
+ Coverage    27.87%   30.94%   +3.06%     
===========================================
  Files          503      541      +38     
  Lines        33922    26272    -7650     
  Branches         0      260     +260     
===========================================
- Hits          9455     8129    -1326     
+ Misses       24467    18103    -6364     
- Partials         0       40      +40     
Impacted Files Coverage Δ
components/date-picker/internal/DatePickerBase.cs 63.95% <47.61%> (+15.96%) ⬆️
components/date-picker/RangePicker.razor.cs 54.28% <82.05%> (+31.92%) ⬆️
...s/date-picker/internal/DatePickerTemplate.razor.cs 62.68% <100.00%> (+32.15%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 52.91% <0.00%> (-2.69%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) ⬇️
... and 448 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00dd6f...d0d2074. Read the comment docs.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ElderJames ElderJames merged commit 09337d8 into ant-design-blazor:feature Jul 25, 2022
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
… selecting second value (#2570)

* fix: (module: rangepicker): same quarter when end set first is disabled

* feat:(module:rangepicker): disable time input according to range values

* fix:(module:rangepicker): input allows to set later start or earlier end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants