-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:(module:rangepicker): date selection #2570
fix:(module:rangepicker): date selection #2570
Conversation
In the ant.design the time input is not disabled. Instead, the values change their places when the start value is later than the end value or vice versa. I already implemented the behavior when hours, minutes, and seconds in the time input get disabled, and then I checked out the original ant.design and IDK now 🤷♂️ I've committed the change. Check it out @ElderJames I found another bug where the keyboard input allows to enter the later value as the start of the range. Fixed in the last commit. |
Codecov Report
@@ Coverage Diff @@
## feature #2570 +/- ##
===========================================
+ Coverage 27.87% 30.94% +3.06%
===========================================
Files 503 541 +38
Lines 33922 26272 -7650
Branches 0 260 +260
===========================================
- Hits 9455 8129 -1326
+ Misses 24467 18103 -6364
- Partials 0 40 +40
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
… selecting second value (#2570) * fix: (module: rangepicker): same quarter when end set first is disabled * feat:(module:rangepicker): disable time input according to range values * fix:(module:rangepicker): input allows to set later start or earlier end
🤔 This is a ...
🔗 Related issue link
#1429
💡 Background and solution
Fixes quarter/week range selection when the end value is set first.
📝 Changelog
☑️ Self Check before Merge