-
-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:(module:datepicker): wrong day headers when FirstDayOfWeek!=Sunday #2571
fix:(module:datepicker): wrong day headers when FirstDayOfWeek!=Sunday #2571
Conversation
Codecov Report
@@ Coverage Diff @@
## feature #2571 +/- ##
===========================================
+ Coverage 27.68% 30.94% +3.25%
===========================================
Files 503 541 +38
Lines 34064 26274 -7790
Branches 0 260 +260
===========================================
- Hits 9430 8130 -1300
+ Misses 24634 18104 -6530
- Partials 0 40 +40
Continue to review full report at Codecov.
|
@Alexbits I think we need to add some notes to the document. |
I'm not sure where @ElderJames? |
Here site\AntDesign.Docs\Demos\Components\DatePicker\doc\index.en-US.md |
@Alexbits Please solve the conflicts |
…ay (#2571) * fix:(module:datepicker): wrong day headers when FirstDayOfWeek!=Sunday * add:(module:datepicker): localization note * fix the order of shortWeekDays in zh-CN Co-authored-by: James Yeung <shunjiey@hotmail.com>
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Fixes the day headers order issue from #1551
The fix is not ideal maybe. Because if the user changes the order in
DateLocale.ShortWeekDays
this will still cause wrong day headers. So the order of days inDateLocale.ShortWeekDays
should be preserved.Anyways, it's better than what we have now.
📝 Changelog
☑️ Self Check before Merge